Fix RangeError when baseDelayMs is 0 in RetryInterceptor#17
Conversation
…seDelayMs is greater than 0 before generating a random jitter to prevent a RangeError. Added a test to verify initialization with 0 delay doesn't crash during retry logic. Co-authored-by: insign <1113045+insign@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Fixes a potential crash in
RetryInterceptorwhere initializing it withbaseDelayMs: 0would result in aRangeErrorduring jitter calculation becauseRandom().nextInt()requires the max value to be positive and greater than 0.This improvement makes the code more robust against configuration values and adds proper testing to ensure delays can be entirely disabled safely. No external files or markdown files needed updates.
PR created automatically by Jules for task 5163655667391014827 started by @insign