-
Notifications
You must be signed in to change notification settings - Fork 1
feat: harden API client, align with mcp-ecosystem standards #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c40ce60
Add connection validation, stdio safety, and improved error handling
jack-arturo 164b432
feat: harden API client, align with mcp-ecosystem standards
jack-arturo 67c09e3
Remove README.md from assets and enhance stdio test for stderr capture
jack-arturo 7ca47ed
Enhance stdio-clean test for improved process termination handling
jack-arturo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| ".": "1.0.0" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| # Brand Assets for Desktop Extension | ||
|
|
||
| This directory contains visual assets for the Claude Desktop Extension. | ||
|
|
||
| ## Required Icons | ||
|
|
||
| Create VGP-branded icons with orange (#F97316) accent: | ||
|
|
||
| | File | Size | Purpose | | ||
| |------|------|---------| | ||
| | `icon.png` | 128x128 | Primary icon | | ||
| | `icon-16.png` | 16x16 | Small UI elements | | ||
| | `icon-32.png` | 32x32 | Medium UI elements | | ||
| | `icon-64.png` | 64x64 | Large UI elements | | ||
|
|
||
| **Design guidelines:** | ||
| - Use transparent background | ||
| - VGP orange (#F97316) as primary color | ||
| - Simple design that scales well to small sizes | ||
| - Consider EDD shopping cart or download icon theme | ||
|
|
||
| ## Screenshots | ||
|
|
||
| Place in `screenshots/` directory: | ||
|
|
||
| | File | Description | | ||
| |------|-------------| | ||
| | `sales-query.png` | Claude conversation querying sales data | | ||
| | `customer-lookup.png` | Customer information retrieval example | | ||
|
|
||
| **Screenshot guidelines:** | ||
| - 1280x800 or similar aspect ratio | ||
| - Show Claude Desktop UI | ||
| - Demonstrate real tool usage | ||
| - Blur any sensitive data | ||
|
|
||
| ## Generating Icons | ||
|
|
||
| Quick generation with ImageMagick (if VGP logo exists): | ||
|
|
||
| ```bash | ||
| # From a source logo | ||
| convert logo.png -resize 128x128 icon.png | ||
| convert logo.png -resize 64x64 icon-64.png | ||
| convert logo.png -resize 32x32 icon-32.png | ||
| convert logo.png -resize 16x16 icon-16.png | ||
| ``` | ||
|
|
||
| Or create manually in Figma/Sketch using VGP brand guidelines. |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.