fix: use RELEASE_PLEASE_TOKEN so PR triggers CI checks#18
Merged
Conversation
PRs created by GITHUB_TOKEN don't trigger other workflows. Use the org-level PAT so the release-please PR triggers CI and satisfies the required 'test' status check. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Caution Review failedThe pull request is closed. 📝 WalkthroughSummary by CodeRabbit
WalkthroughA GitHub Actions workflow token has been added to authenticate the Release Please action. The token references a secret configured in the repository settings, enabling the action to perform authenticated operations without additional configuration changes to existing inputs. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PRs created by
GITHUB_TOKENdon't trigger other workflows (GitHub security feature). This means the release-please PR never gets CI checks, and the org ruleset's requiredteststatus check stays stuck.Uses the org-level
RELEASE_PLEASE_TOKENPAT so release-please PRs trigger CI normally.Made with Cursor