Add MCP extension files and update docs#6
Conversation
Added manifest.json and mcp-edd.mcpb for MCP extension packaging. Updated README with quick install instructions and new build:extension script in package.json. Added .mcpbignore for packaging exclusions.
📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughAdds MCP plugin packaging and configuration for an Easy Digital Downloads integration: new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @manifest.json:
- Around line 46-72: Manifest "name" and package.json "mcpName" are using
different identifiers ("mcp-edd" vs "io.github.verygoodplugins/mcp-edd"); update
one to be canonical so tools surface a single identifier—either change manifest
"name" to "io.github.verygoodplugins/mcp-edd" or change package.json "mcpName"
to "mcp-edd" (whichever is intended), and ensure any references in code/config
that use mcpName or name (e.g., deployment scripts, MCPB/Claude integrations)
are updated to match the chosen canonical identifier.
In @README.md:
- Around line 19-33: Update the README’s “Download mcp-edd.mcpb” link so it
points directly to the release asset URL (the .mcpb file) or change the link
text to make clear it goes to the release page; specifically edit the line
containing the link text "Download mcp-edd.mcpb" to either use the direct asset
download URL for the current release asset or relabel it to "Release page
(download .mcpb asset)" to avoid misleading users and potential 404s.
🧹 Nitpick comments (2)
package.json (1)
22-33: Add@anthropic-ai/mcpbtodevDependenciesfor reproducible builds.The recommended approach for reproducible builds is to install
@anthropic-ai/mcpbas a dev dependency, which automatically locks the version viapackage-lock.json. Then run the simplenpx @anthropic-ai/mcpb packcommand (no explicit version pinning needed).Add to
"devDependencies"section:"@anthropic-ai/mcpb": "<LATEST_VERSION>"Then update the script:
- "build:extension": "npm run build && npx @anthropic-ai/mcpb pack", + "build:extension": "npm run build && npx @anthropic-ai/mcpb pack",If the build runs in non-interactive environments (CI), consider adding the
--yesflag to suppress prompts, but this is less critical once the package is a locked dev dependency..mcpbignore (1)
1-30: Add.env*patterns to prevent accidental credential packaging.
.mcpbignorealready supports.gitignore-style patterns including!negation (as shown by!README.md), so the suggested patterns will work as expected.Proposed change
# Other *.md !README.md +.env +.env.* .gitignore package-lock.jsonWhile no
.envfiles currently exist in the repository, explicitly ignoring.env*follows standard practice for bundled packages to prevent accidental credential leakage if environment files are added later.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.mcpbignoreREADME.mdmanifest.jsonmcp-edd.mcpbpackage.json
🔇 Additional comments (1)
manifest.json (1)
1-45: The manifest schema and templating are correct. MCPB v0.2 supports both${__dirname}in args and${user_config.*}interpolation in env variables, and individual user_config fields use"required": trueas shown here—all matching the official specification and examples.
Changed the package name in manifest.json and src/index.ts to 'io.github.verygoodplugins/mcp-edd' for consistency and improved identification. Updated README to clarify download instructions.
Added manifest.json and mcp-edd.mcpb for MCP extension packaging. Updated README with quick install instructions and new build:extension script in package.json. Added .mcpbignore for packaging exclusions.