Skip to content

feat: make cert-manager Gateway API ready #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tadas Sutkaitis (fitbeard) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: make cert-manager Gateway API ready #286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions roles/cert_manager/vars/v1.15.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
cert_manager_image_startupapicheck: "quay.io/jetstack/cert-manager-startupapicheck:{{ cert_manager_image_tag }}"

_cert_manager_version_values:
extraArgs:
- --enable-gateway-api

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep Gateway API opt-in until CRDs are guaranteed

For any playbook that selects cert-manager v1.15 before installing Gateway API CRDs, this unconditional --enable-gateway-api makes the cert-manager controller fail during startup: upstream cert-manager v1.15 pkg/controller/context.go:buildClients returns an error when EnableGatewayAPI is true and gateway.networking.k8s.io/v1 resources are absent. I checked this role has no dependency/order ensuring envoy_gateway or the Gateway API CRDs run first, and the cert_manager molecule scenario prepares only Kubernetes, so the standalone role can now deploy a CrashLooping controller instead of a healthy cert-manager release. Please make this opt-in or add an explicit CRD prerequisite/order before enabling it by default.

Useful? React with 👍 / 👎.

startupapicheck:
image:
repository: "{{ cert_manager_image_startupapicheck | vexxhost.kubernetes.docker_image('name') }}"
Expand Down
Loading