fix(loki): preserve default alert rules with custom files#3995
Open
Yaguang Tang (yaguangtang) wants to merge 1 commit into
Open
fix(loki): preserve default alert rules with custom files#3995Yaguang Tang (yaguangtang) wants to merge 1 commit into
Yaguang Tang (yaguangtang) wants to merge 1 commit into
Conversation
Yaguang Tang (yaguangtang)
force-pushed
the
codex/loki-custom-rule-merge
branch
2 times, most recently
from
8472d96 to
849312e
Compare
Move the default Loki alert rules out of the generic loki_helm_values merge path and build the loki-alerting-rules ConfigMap explicitly from dedicated rule-file variables. This keeps the Atmosphere-provided rules in place while letting operators add extra rule files through loki_alert_rule_files without replacing the default ConfigMap object or other list-valued Helm settings. Add a Loki role test covering the default rule file and custom rule file coexistence, and include a release note describing the new custom rule file behavior. Signed-off-by: Yaguang Tang <yaguang.tang@vexxhost.com>
Yaguang Tang (yaguangtang)
force-pushed
the
codex/loki-custom-rule-merge
branch
from
849312e to
145e0dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loki_alert_rule_filesas the supported way to append extra Loki rule filesTesting
go test ./roles/loki -count=1