fix: recover stale deleted nodegroups#1054
Open
Rico Lin (ricolin) wants to merge 2 commits into
Open
Conversation
Recover nodegroups stuck in DELETE_FAILED when the CAPI topology and backend resources for that nodegroup are already gone. The driver now completes the Magnum nodegroup delete and runs best-effort server-group cleanup only after verifying the MachineDeployment, MachineSets, Machines, and OpenStackMachines are absent. Assisted-By: Codex <noreply@openai.com> Signed-off-by: Rico Lin <rlin@vexxhost.com>
Rico Lin (ricolin)
force-pushed
the
fix-nodegroup-delete-reconcile
branch
2 times, most recently
from
2dd91a9 to
f4cf129
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DELETE_FAILEDwhen the CAPI topology and backend nodegroup resources are already goneDELETE_FAILEDunchanged while any MachineDeployment, MachineSet, Machine, or OpenStackMachine still exists for the nodegroupValidation
PYTHONPATH=$PWD .tox/py310/bin/pytest -q magnum_cluster_api/tests/unit/test_driver.py -k 'recovers_stale_delete_failed or keeps_delete_failed'git diff --checkPYTHONPATH=$PWD .tox/py310/bin/python -m compileall -q magnum_cluster_api/driver.py magnum_cluster_api/tests/unit/test_driver.pyNote: the local tox env needed
setuptools<81because newer setuptools no longer providespkg_resources, which this tree still imports throughresources.py.