fix: add control-plane label to topology metadata#1056
Open
Rico Lin (ricolin) wants to merge 3 commits into
Open
fix: add control-plane label to topology metadata#1056Rico Lin (ricolin) wants to merge 3 commits into
Rico Lin (ricolin) wants to merge 3 commits into
Conversation
Render both the legacy master label and the modern control-plane label on control-plane topology metadata so the OpenStack CCM nodeSelector can match the generated control-plane node. Assisted-By: Codex <noreply@openai.com> Signed-off-by: Rico Lin <rlin@vexxhost.com>
Rico Lin (ricolin)
force-pushed
the
codex/control-plane-label
branch
2 times, most recently
from
8bb8cf4 to
a5c313e
Compare
Format the new control-plane label unit test with black. Signed-off-by: Rico Lin <rlin@vexxhost.com> Assisted-By: Codex <noreply@openai.com>
Rico Lin (ricolin)
force-pushed
the
codex/control-plane-label
branch
from
557b3da to
2b4e09b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node-role.kubernetes.io/control-planelabel to Cluster API control-plane topology metadatanode-role.kubernetes.io/masterlabel for compatibilityValidation
uv run ruff check magnum_cluster_api/resources.py magnum_cluster_api/tests/unit/test_resources.pyuv run pytest magnum_cluster_api/tests/unit/test_resources.py::test_cluster_control_plane_labels_match_cloud_controller_manageruv run pytest magnum_cluster_api/tests/unit/test_resources.py