Skip to content

feat: docker#739

Merged
magne4000 merged 9 commits into
mainfrom
magne4000/dev
May 28, 2026
Merged

feat: docker#739
magne4000 merged 9 commits into
mainfrom
magne4000/dev

Conversation

@magne4000

@magne4000 magne4000 commented May 28, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features

    • Added Docker as a standalone hosting option.
    • Dokploy now depends on and integrates with Docker and is no longer hidden/disabled.
    • Feature detection now recognizes Docker alongside existing platforms.
  • Refactor

    • Simplified tooltip rendering for feature buttons for more consistent UI behavior.
  • Chores

    • Updated package manager declaration and refined workspace build allowlist configuration.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@magne4000, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 12 minutes and 30 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 332be7b0-3dd7-4575-871a-242445e595d6

📥 Commits

Reviewing files that changed from the base of the PR and between 9dec80d and 54059ff.

📒 Files selected for processing (1)
  • packages/tests/src/common.ts
📝 Walkthrough

Walkthrough

Adds Docker as a hosting feature and makes Dokploy depend on it; BatiSet platform detection and docker-compose boilerplate reference Docker. Tooltip's tip prop is optional and FormControl replaces EnrichedTooltip with Tooltip. Workspace and package manager metadata updated.

Changes

Docker Feature and Dependency Architecture

Layer / File(s) Summary
Docker Feature Definition and Dokploy Dependency
packages/features/src/features.ts
Docker hosting feature is added with flag, image, URL, tagline, and docs metadata. Dokploy is updated to declare dependsOn: ["docker"] and the disabled and invisibleCli properties are removed.
Platform Detection and Boilerplate Configuration
packages/features/src/helpers.ts, boilerplates/docker-compose/bati.config.ts
The BatiSet.hasUD getter includes "docker" as a recognized platform. The docker-compose boilerplate configuration checks for the "docker" capability instead of "dokploy".
Repository Tooling and Workspace Metadata
package.json, pnpm-workspace.yaml
Root packageManager bumped to pnpm@11.4.0 and allowBuilds allowlist added to pnpm-workspace.yaml.

FormControl Tooltip Simplification

Layer / File(s) Summary
Tooltip Props Type Update
website/components/Tooltip.tsx
The tip prop is changed from required to optional in the Tooltip component's props type.
FormControl Tooltip Migration
website/components/FormControl.tsx
FormControl switches from EnrichedTooltip with extensive configuration to the simpler Tooltip component, passing only the tip text and a CSS class.
  • Possibly related PRs:
    • vikejs/bati#719: Modifies hosting-feature modeling and BatiSet.hasUD logic; touches similar feature-flag paths.
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'feat: docker' is overly vague and generic. While it indicates a feature addition, it lacks specificity about what Docker-related functionality was added and does not convey meaningful information about the actual changes. Consider a more descriptive title such as 'feat: add Docker hosting feature and update Dokploy to depend on Docker' to clearly communicate the main changes to reviewers scanning the history.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@magne4000 magne4000 marked this pull request as ready for review May 28, 2026 10:20
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Actionable comments posted: 0

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Actionable comments posted: 0

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Actionable comments posted: 0

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pnpm-workspace.yaml`:
- Around line 17-18: The test helper currently reads onlyBuiltDependencies and
will miss new packages listed under allowBuilds; update the helper in
packages/tests/src/common.ts to first look for allowBuilds (and treat it as the
canonical list) and fall back to onlyBuiltDependencies when allowBuilds is
absent, then normalize/return that combined list so callers using the helper see
both `@browserless/goto` and re2; ensure the symbol handling (the existing
function that parses onlyBuiltDependencies) is renamed or extended to reference
allowBuilds with legacy fallback and same return shape.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2b843ba5-c652-4cc8-8898-9999825850a6

📥 Commits

Reviewing files that changed from the base of the PR and between 00ed348 and 9dec80d.

📒 Files selected for processing (1)
  • pnpm-workspace.yaml

Comment thread pnpm-workspace.yaml
@magne4000 magne4000 merged commit 383ad79 into main May 28, 2026
350 of 351 checks passed
@magne4000 magne4000 deleted the magne4000/dev branch May 28, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant