fix: use convert as fallback for imagemagick v6#251
Open
Alexander-Hou wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thank you for this amazing project! These GRUB themes are incredibly well-designed and bring a modern look to my Linux setup.
On some stable distributions like Ubuntu 24.04 LTS, ImageMagick v6 is still the default, which uses the convert command instead of magick. This PR adds a fallback check to ensure compatibility across different ImageMagick versions.
Here is the problem before altering the code.
On Ubuntu 24.04 LTS (ImageMagick v6), the script fails because the magick command does not exist:
After altering the code, the script correctly handles the command fallback. Here is the successful output:
alexander-ThinkBook-16-G7-IAH% sudo ./install.sh -t stylish -c 3200x1600
Thanks again for your hard work on these themes!