Add test cases from codex#114
Open
arthurvergacas wants to merge 19 commits into
Open
Conversation
f1e6c97 to
549899f
Compare
549899f to
44f5b6b
Compare
478f950 to
cf06945
Compare
Grillo-0
requested changes
May 17, 2026
| struct compiler_ctx comp = compiler_ctx_init(&ctx->allocator); | ||
|
|
||
| va_list ap; | ||
| va_start(ap, prg_cstr); |
Member
There was a problem hiding this comment.
No need for this fancy var args, just let the user pass the vec of libraries
Collaborator
Author
There was a problem hiding this comment.
i used this pattern because it was also used in vunit_run_vinumc_ok
should we change vunit_run_vinumc_ok as well??
vinum/subprojects/vunit/vunit.c
Lines 371 to 384 in b4b69e8
Collaborator
Author
There was a problem hiding this comment.
we agreed to use a vec and instad create a helper function inside vec that receives the varargs.
We will take another look
a37abe4 to
6d5df09
Compare
fdd3b77 to
7febf6f
Compare
7febf6f to
07d0a08
Compare
07d0a08 to
80f4949
Compare
JeanJPNM
requested changes
Jun 20, 2026
Comment on lines
+27
to
+39
| struct vunit_test tests[] = { | ||
| { .name = "Blank reduction collapses newlines into one space", | ||
| .test_func = test_blank_reduction_across_newline, | ||
| .todo = true, | ||
| .todo_msg = "blank reduction across newlines not implemented" }, | ||
| { .name = "Leading and trailing blanks are suppressed", | ||
| .test_func = test_leading_trailing_blanks_suppressed, | ||
| .todo = true, | ||
| .todo_msg = "leading/trailing blank suppression not implemented" }, | ||
| { .name = "Blanks around symbol field are ignored", | ||
| .test_func = test_symbol_field_blanks_ignored }, | ||
| {}, | ||
| }; |
Member
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.