vinumc: report errors line, column and text#143
Draft
artP2 wants to merge 1 commit into
Draft
Conversation
Grillo-0
reviewed
Jun 11, 2026
Grillo-0
reviewed
Jun 11, 2026
| return TEXT; | ||
| } | ||
|
|
||
| static void update_line_buffer(struct compiler_ctx *ctx, const char *text) { |
Member
There was a problem hiding this comment.
Use a vut_sv here to avoid copying
Contributor
Author
There was a problem hiding this comment.
YY_USER_ACTION is called after each flex rule, so we need to accumulate the chars that composes the line, can't use a vut_sv from the args text
Grillo-0
requested changes
Jun 11, 2026
artP2
force-pushed
the
report-errors
branch
2 times, most recently
from
2180edf to
22d0572
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.