vunit: ignore SIGPIPE and tolerate EPIPE when piping input to child#146
Merged
Conversation
JeanJPNM
approved these changes
Jun 13, 2026
vunit_run_vinumc writes the test input to the child's stdin without guarding against the child closing the read end early. When the child exits before reading (e.g. `vinumc -h`, which doesn't touch stdin), the write hits a closed pipe and SIGPIPE kills the parent test process -- observed as `ERROR killed by signal 13 SIGPIPE` on Linux/gcc, where vinumc exits faster than the write completes. Ignore SIGPIPE on entry and treat EPIPE as a non-fatal "child didn't read stdin"; downstream output/exit-status assertions remain the source of truth.
37dfff9 to
76eb1b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vunit_run_vinumc writes the test input to the child's stdin without guarding against the child closing the read end early. When the child exits before reading (e.g.
vinumc -h, which doesn't touch stdin), the write hits a closed pipe and SIGPIPE kills the parent test process -- observed asERROR killed by signal 13 SIGPIPEon Linux/gcc, where vinumc exits faster than the write completes. Ignore SIGPIPE on entry and treat EPIPE as a non-fatal "child didn't read stdin"; downstream output/exit-status assertions remain the source of truth.