Refactor: Chaning vlek_load api to thake in WrappedVlekHashstick#320
Merged
Conversation
Since we're updating the major version, I'd prefer having users pass the UAPI structure to the API instead of a slice. By using the UAPI struct, the library can perform the appropriate length and reserved field checks before passing the data to the firmware. This gives us better validation of the data upfront. This approach is cleaner than passing a raw slice and makes it easier to work with compared to manually managing arrays or buffers. Signed-off-by: DGonzalezVillal <Diego.GonzalezVillalobos@amd.com>
DGonzalezVillal
requested review from
larrydewey and
tylerfanelli
as code owners
tylerfanelli
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we're updating the major version, I'd prefer having users pass the UAPI structure to the API instead of a slice. By using the UAPI struct, the library can perform the appropriate length and reserved field checks before passing the data to the firmware. This gives us better validation of the data upfront.
This approach is cleaner than passing a raw slice and makes it easier to work with compared to manually managing arrays or buffers.