[codex] Remove COORDINATE_SYSTEM.IDENTITY alias (v10) - #10376
[codex] Remove COORDINATE_SYSTEM.IDENTITY alias (v10)#10376charlieforward9 wants to merge 3 commits into
Conversation
|
Let's hold on merging while we focus master on 9.4 betas |
|
@copilot resolver los conflictos de combinación en esta rama. |
Merged |
| return new IconLayer({ | ||
| id: 'text', | ||
| coordinateSystem: COORDINATE_SYSTEM.IDENTITY, | ||
| coordinateSystem: COORDINATE_SYSTEM.CARTESIAN, |
There was a problem hiding this comment.
Nit: I believe that we are using string constants now for the coordinateSystem prop (so that apps don't have to import COORDINATE_SYSTEM, the enum values should be deprecated and avoided in code.
6baa5de to
c008eb2
Compare
Greptile SummaryThis PR removes the deprecated
Confidence Score: 4/5The implementation appears safe to merge after adding the missing v10 migration note for the removed public alias. The code replacements preserve the alias's former cartesian behavior, but users upgrading with IDENTITY references currently lack repository documentation explaining the resulting build or runtime failure and required replacement. Files Needing Attention: modules/core/src/lib/constants.ts and the v10 upgrade or release documentation
|
| Filename | Overview |
|---|---|
| modules/core/src/lib/constants.ts | Removes the deprecated IDENTITY getter correctly, but the public API removal lacks corresponding migration documentation. |
| showcases/ascii/ascii-layer/ascii-layer.js | Replaces IDENTITY with its equivalent and supported 'cartesian' value. |
| showcases/graph/graph-layer/graph-layer.js | Updates the default coordinate system to the equivalent supported string value. |
| test/apps/svg-interoperability/app.jsx | Migrates both active layer configurations from IDENTITY to cartesian. |
| test/modules/mesh-layers/utils.spec.ts | Updates test inputs to valid coordinate-system string constants while preserving behavioral coverage. |
Reviews (1): Last reviewed commit: "Merge branch 'master' into codex/remove-..." | Re-trigger Greptile
| @@ -52,16 +51,6 @@ export const COORDINATE_SYSTEM = { | |||
| CARTESIAN: 'cartesian' | |||
There was a problem hiding this comment.
Document the removed public alias
The v10 migration and release documentation does not record that COORDINATE_SYSTEM.IDENTITY was removed or that callers must use COORDINATE_SYSTEM.CARTESIAN. This leaves TypeScript consumers without guidance for the resulting compile error and JavaScript consumers without guidance when the missing property becomes an invalid undefined coordinate system at runtime.
Goal
Remove the deprecated
COORDINATE_SYSTEM.IDENTITYcompatibility alias for the v10 cleanup.Changes
Object.defineProperty(COORDINATE_SYSTEM, 'IDENTITY', ...)getter and its warning-onlylogimport.COORDINATE_SYSTEM.CARTESIAN.Documentation
COORDINATE_SYSTEM.IDENTITYhas been removed; useCOORDINATE_SYSTEM.CARTESIANinstead.Validation
yarn test-headless test/modules/core/shaderlib/project/project-functions.spec.ts test/modules/core/shaderlib/project/viewport-uniforms.spec.ts test/modules/mesh-layers/utils.spec.ts