Skip to content

[codex] Remove COORDINATE_SYSTEM.IDENTITY alias (v10) - #10376

Open
charlieforward9 wants to merge 3 commits into
masterfrom
codex/remove-coordinate-system-identity
Open

[codex] Remove COORDINATE_SYSTEM.IDENTITY alias (v10)#10376
charlieforward9 wants to merge 3 commits into
masterfrom
codex/remove-coordinate-system-identity

Conversation

@charlieforward9

@charlieforward9 charlieforward9 commented Jun 13, 2026

Copy link
Copy Markdown
Member

Goal

Remove the deprecated COORDINATE_SYSTEM.IDENTITY compatibility alias for the v10 cleanup.

Changes

  • Removed the deprecated Object.defineProperty(COORDINATE_SYSTEM, 'IDENTITY', ...) getter and its warning-only log import.
  • Replaced active test app and showcase usages with COORDINATE_SYSTEM.CARTESIAN.
  • Removed unit-test coverage that only asserted the deprecated alias behavior.

Documentation

  • Add this to the v10 What's New / release notes: COORDINATE_SYSTEM.IDENTITY has been removed; use COORDINATE_SYSTEM.CARTESIAN instead.

Validation

  • yarn test-headless test/modules/core/shaderlib/project/project-functions.spec.ts test/modules/core/shaderlib/project/viewport-uniforms.spec.ts test/modules/mesh-layers/utils.spec.ts
  • Pre-commit hook during commit: module/test/example lint and Prettier checks, lockfile validation, node Vitest smoke tests. Existing lint warnings were reported, with 0 errors.

@charlieforward9 charlieforward9 added this to the v10 milestone Jun 13, 2026 — with ChatGPT Codex Connector
@coveralls

coveralls commented Jun 13, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 82.495% (-0.002%) from 82.497% — codex/remove-coordinate-system-identity into master

@charlieforward9
charlieforward9 marked this pull request as ready for review June 13, 2026 07:00
@chrisgervang

Copy link
Copy Markdown
Collaborator

Let's hold on merging while we focus master on 9.4 betas

@charlieforward9

Copy link
Copy Markdown
Member Author

@copilot resolver los conflictos de combinación en esta rama.

Copilot AI commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@copilot resolver los conflictos de combinación en esta rama.

Merged origin/master into this branch. The only conflict was in modules/core/src/lib/constants.ts: master added DoubleClickDrag to the mjolnir.js import while this PR removed the log import (no longer needed after removing the deprecated IDENTITY getter). Resolution: kept DoubleClickDrag, dropped log.

return new IconLayer({
id: 'text',
coordinateSystem: COORDINATE_SYSTEM.IDENTITY,
coordinateSystem: COORDINATE_SYSTEM.CARTESIAN,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I believe that we are using string constants now for the coordinateSystem prop (so that apps don't have to import COORDINATE_SYSTEM, the enum values should be deprecated and avoided in code.

@ibgreen
ibgreen force-pushed the codex/remove-coordinate-system-identity branch from 6baa5de to c008eb2 Compare July 27, 2026 12:12
@ibgreen ibgreen changed the title [codex] Remove COORDINATE_SYSTEM.IDENTITY alias [codex] Remove COORDINATE_SYSTEM.IDENTITY alias (v10) Jul 27, 2026
@greptile-apps

greptile-apps Bot commented Aug 19, 2026

Copy link
Copy Markdown

Greptile Summary

This PR removes the deprecated COORDINATE_SYSTEM.IDENTITY compatibility getter and migrates repository examples and tests to its cartesian value.

  • Removes the warning-only logging dependency associated with the alias.
  • Updates showcase and test-app coordinate-system configuration.
  • Deletes tests dedicated to the removed compatibility behavior.
  • Still needs the v10 migration or release-note entry named in the PR description.

Confidence Score: 4/5

The implementation appears safe to merge after adding the missing v10 migration note for the removed public alias.

The code replacements preserve the alias's former cartesian behavior, but users upgrading with IDENTITY references currently lack repository documentation explaining the resulting build or runtime failure and required replacement.

Files Needing Attention: modules/core/src/lib/constants.ts and the v10 upgrade or release documentation

Important Files Changed

Filename Overview
modules/core/src/lib/constants.ts Removes the deprecated IDENTITY getter correctly, but the public API removal lacks corresponding migration documentation.
showcases/ascii/ascii-layer/ascii-layer.js Replaces IDENTITY with its equivalent and supported 'cartesian' value.
showcases/graph/graph-layer/graph-layer.js Updates the default coordinate system to the equivalent supported string value.
test/apps/svg-interoperability/app.jsx Migrates both active layer configurations from IDENTITY to cartesian.
test/modules/mesh-layers/utils.spec.ts Updates test inputs to valid coordinate-system string constants while preserving behavioral coverage.

Reviews (1): Last reviewed commit: "Merge branch 'master' into codex/remove-..." | Re-trigger Greptile

@@ -52,16 +51,6 @@ export const COORDINATE_SYSTEM = {
CARTESIAN: 'cartesian'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Document the removed public alias

The v10 migration and release documentation does not record that COORDINATE_SYSTEM.IDENTITY was removed or that callers must use COORDINATE_SYSTEM.CARTESIAN. This leaves TypeScript consumers without guidance for the resulting compile error and JavaScript consumers without guidance when the missing property becomes an invalid undefined coordinate system at runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants