-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat(core): support pointer-anchored zoom in GlobeView #10385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
charlieforward9
wants to merge
17
commits into
codex/shared-controller-zoom-anchor
Choose a base branch
from
codex/globe-anchored-zoom
base: codex/shared-controller-zoom-anchor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
5ef53f5
feat(core): add GlobeView pointer zoom option
charlieforward9 5b988fe
feat(core): anchor LinearInterpolator transitions on GlobeViewport
charlieforward9 9495132
refactor(core): tidy GlobeViewport anchor helpers
charlieforward9 9f1d80b
fix(core): apply updated GlobeView zoom anchor option
charlieforward9 c9a70ad
fix(core): stabilize GlobeView pointer zoom
charlieforward9 10efe94
fix(core): address globe zoom review feedback
charlieforward9 4b98253
fix(core): recover globe pointer zoom anchors
charlieforward9 4179907
fix(core): always set GlobeState.zoomAround (fix HMR pointer-zoom dro…
charlieforward9 ce2b6ee
Merge branch 'master' into codex/globe-anchored-zoom
charlieforward9 8450a17
Merge remote-tracking branch 'upstream/master' into codex/pr-10385-sh…
charlieforward9 8f81051
refactor(core): share pointer zoom policy across controllers
charlieforward9 ece9795
fix(test-app): use current point radius accessor
charlieforward9 e8bbdf1
Merge shared zoom anchor base for stacked review
charlieforward9 27fb924
refactor(core): clarify globe anchor projection math
charlieforward9 b39f5f4
Merge latest shared zoom anchor base
charlieforward9 ac03464
Merge remote-tracking branch 'upstream/codex/shared-controller-zoom-a…
charlieforward9 8d771b0
fix(core): center globe zoom outside visible sphere
charlieforward9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.