WIP: Subtitles track - #165
Open
Jiyuu wants to merge 3 commits into
Open
Conversation
added 3 commits
July 21, 2023 13:14
Open
Owner
|
@Jiyuu Thanks for this, really appreciate it. Even if it doesn't get finished, it is a good starting point for how to do it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just putting this out there as a first draft for native (i.e. softsub) subtitles to show how it might technically be done.
Still has a bunch of unrelated stuff so do not merge.
I might polish this myself, but if not this could be a more accessible starting point for anyone else that would like to go about delivering it..