Skip to content

m2d#1588

Merged
thinkasany merged 2 commits intodevfrom
main
Mar 26, 2026
Merged

m2d#1588
thinkasany merged 2 commits intodevfrom
main

Conversation

@thinkasany
Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings March 26, 2026 06:54
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cn-vitejs-dev Ready Ready Preview, Comment Mar 27, 2026 5:59am

Request Review

@thinkasany thinkasany merged commit 8b63eb6 into dev Mar 26, 2026
4 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bumps the docs site’s VitePress dependency from 2.0.0-alpha.16 to 2.0.0-alpha.17, updating the lockfile to match and introducing a small (currently commented) config change in the VitePress config.

Changes:

  • Update vitepress to 2.0.0-alpha.17 in package.json.
  • Regenerate pnpm-lock.yaml to reflect the new VitePress version and updated transitive dependencies.
  • Add a commented-out import placeholder for vitepress-plugin-llms in .vitepress/config.ts.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
package.json Bumps vitepress to 2.0.0-alpha.17.
pnpm-lock.yaml Lockfile updates for the VitePress bump and transitive dependency changes.
.vitepress/config.ts Adds a commented import line related to an (unused) plugin.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

'@iconify-json/simple-icons': 1.2.70
'@shikijs/core': 3.22.0
'@shikijs/transformers': 3.21.0
'@shikijs/transformers': 3.23.0
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lockfile now resolves VitePress to use a mixed Shiki set (@shikijs/core/@shikijs/types at 3.22.0 but @shikijs/transformers at 3.23.0). Since @shikijs/transformers@3.23.0 depends on @shikijs/core@3.23.0, this introduces duplicate Shiki cores and can cause subtle runtime incompatibilities. Consider aligning Shiki-related versions (e.g., via pnpm.overrides/dependency bumps so core/types/transformers match) and then regenerating the lockfile.

Suggested change
'@shikijs/transformers': 3.23.0
'@shikijs/transformers': 3.22.0

Copilot uses AI. Check for mistakes.
groupIconMdPlugin,
groupIconVitePlugin,
} from 'vitepress-plugin-group-icons'
// import llmstxt from 'vitepress-plugin-llms'
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds a commented-out import for vitepress-plugin-llms, but the plugin isn’t enabled (and doesn’t appear in package.json). Keeping commented code in the config can be confusing long-term—either remove this line (and rely on the existing commented block further down if needed), or add the dependency and wire it up for real.

Suggested change
// import llmstxt from 'vitepress-plugin-llms'

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants