Conversation
b8acc1d to
4aeb6ed
Compare
Co-authored-by: Dominik G. <dominik.goepel@gmx.de>
|
ran your test locally and it passed 🥳 3 questions: Do you need to build all packages for the vite test or is a subset ok? this reads like you have templates for vite 5-7, is it possible to focus on the latest template only? |
Yes,
Hmm. I'm realizing I hadn't actually looked into how vite-ecosystem-ci tests against a specific vite release (you know, the whole point of vite-ecosystem-ci). I see now that it's setting I imagine we need to make a small change in our repo to support this explicitly. Is there an existing pattern I can follow? or should I just check for |
|
storybook is also generating test project i think. But they are using yarn so not sure how applicable it is. tbh not sure how your tests make it work when the file that defines the vite versions also imports vite statically. Lazily/dynamically importing vite and picking up the correct path from root package.json overrides was my first hunch too. But maybe you could also switch to vite version as a matrix dimension in tests rather than hardcoding a list in the test itself. |
|
In Storybook we essentially copy the resolutions that vite-ecosystem-ci sets out to our generated projects ("sandboxes") and then run https://github.com/storybookjs/storybook/blob/next/scripts/ecosystem-ci/before-test.js#L31-L44 (We have existing resolutions so there's some merging complexity there which might not be relevant to you) Crucially we do this in the |
|
🤔 Hmm ok thanks both! Right, I can't just specifically resolve vite because other deps like rollup/rolldown/etc. might have overrides too... But just copying Line 618 in 4e3936f |
👋🏼
Adding https://npmx.dev/package/@netlify/vite-plugin to the ecosystem!
✅ Works locally
I wanted to ideally
&&test https://npmx.dev/package/@netlify/vite-plugin-tanstack-start as well (it's in the same monorepo) but it runs e2e tests that deploy to Netlify, which requires a Netlify token env var in CI — is that feasible?