fix(buildkite): validate github_repo_name to prevent path traversal#384
Open
jcc-google wants to merge 1 commit into
Open
fix(buildkite): validate github_repo_name to prevent path traversal#384jcc-google wants to merge 1 commit into
jcc-google wants to merge 1 commit into
Conversation
Validate github_repo_name read from pipeline config to ensure it belongs to vllm-project organization and does not contain path traversal characters. Signed-off-by: Jincheng Chen <chenjincheng@google.com> BUG=b/510375092 TAG=agy CONV=f5118c4a-3577-4dc6-a4b6-1f2abb990935
jcc-google
force-pushed
the
fix/github-path-traversal-b510375092
branch
from
9a695b9 to
1436e04
Compare
Contributor
Author
|
@khluu I'm from Google Core ML team. Our team is working on a security scan to deal with potential security issue. Here is one of our fix. Could you please help to take a look and let me know your opinion and our path forward? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate github_repo_name read from pipeline config to ensure it belongs to vllm-project organization and does not contain path traversal characters.
BUG=b/510375092
TAG=agy
CONV=f5118c4a-3577-4dc6-a4b6-1f2abb990935