Skip to content

fix(buildkite): use coverage binary directly to prevent hijacking #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcc-google wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

fix(buildkite): use coverage binary directly to prevent hijacking #386

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0593d65
fix(buildkite): use coverage binary directly to prevent hijacking
jcc-google Jun 9, 2026
ab1790d
Merge branch 'main' into fix/coverage-hijacking-b510375756
jcc-google Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions buildkite/scripts/upload_codecov.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ done
# Combine all coverage database files into a single .coverage file
# This will apply the [paths] remapping from .coveragerc to normalize paths to vllm/
echo "Combining coverage files..."
COMBINE_OUTPUT=$(python3 -m coverage combine --keep 2>&1)
COMBINE_OUTPUT=$(coverage combine --keep 2>&1)
COMBINE_EXIT=$?

echo "$COMBINE_OUTPUT"
Expand All @@ -72,7 +72,7 @@ echo "Successfully combined coverage files"
# Generate XML report from the combined coverage data
# This will use the path mappings from .coveragerc to normalize paths
echo "Generating XML coverage report..."
python3 -m coverage xml -o coverage.xml
coverage xml -o coverage.xml

if [ ! -f coverage.xml ]; then
echo "Error: Failed to generate coverage.xml"
Expand Down