Skip to content

fix(buildkite): download codecov to secure temp dir to prevent bypass #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcc-google wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −9
Open

fix(buildkite): download codecov to secure temp dir to prevent bypass #387

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f8fffa
fix(buildkite): download codecov to secure temp dir to prevent bypass
jcc-google Jun 9, 2026
0ecf2c4
Merge branch 'main' into fix/codecov-binary-bypass-b510376198
jcc-google Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions buildkite/scripts/upload_codecov.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,15 +83,17 @@ fi
TOTAL_FILES=$(grep -c '<class.*filename=' coverage.xml || echo "0")
echo "Generated coverage.xml with $TOTAL_FILES files"

# Download codecov CLI if not present
if [ ! -f codecov ]; then
echo "Downloading codecov CLI..."
if ! curl -Os https://cli.codecov.io/latest/linux/codecov; then
echo "Warning: Failed to download codecov CLI"
exit 1
fi
chmod +x codecov
# Create a secure temporary directory for the codecov binary
CODECOV_BIN_DIR=$(mktemp -d /tmp/codecov-bin.XXXXXX)
# Ensure cleanup on exit
trap 'rm -rf "$CODECOV_BIN_DIR"' EXIT

echo "Downloading codecov CLI..."
if ! curl -sS -o "$CODECOV_BIN_DIR/codecov" https://cli.codecov.io/latest/linux/codecov; then
echo "Warning: Failed to download codecov CLI"
exit 1
fi
chmod +x "$CODECOV_BIN_DIR/codecov"

# Determine slug (handle fork PRs)
DEFAULT_SLUG="vllm-project/vllm"
Expand Down Expand Up @@ -132,6 +134,6 @@ fi

# Upload to codecov
echo "Uploading to codecov..."
./codecov "${CODECOV_ARGS[@]}" || echo "Warning: codecov upload failed"
"$CODECOV_BIN_DIR/codecov" "${CODECOV_ARGS[@]}" || echo "Warning: codecov upload failed"

exit 0