[Feat] DeepSeek V4 Rebased #40860
Merged
Merged
Conversation
ivanium
requested review from
ApostaC,
DarkLight1337,
LucasWilkinson,
MatthewBonanni,
NickLucche,
ProExpertProg,
WoosukKwon,
aarnphm,
alexm-redhat,
bbrowning,
benchislett,
chaunceyjiang,
heheda12345,
hmellor,
houseroad,
luccafong,
mgoin,
njhill,
orozery,
pavanimajety,
robertgshaw2-redhat,
sfeng33,
tjtanaa,
tlrmchlsmth,
xuechendi,
yewentao256,
youkaichao,
ywang96 and
zhuohan123
as code owners
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This was referenced Apr 27, 2026
Draft
BowenBao
reviewed
Apr 27, 2026
| return Mxfp4MoeBackend.NONE, None | ||
|
|
||
|
|
||
| def select_mxfp4_moe_backend( |
Contributor
There was a problem hiding this comment.
imo we shouldn't create separate select_gpt_oss_mxfp4_moe_backend and select_mxfp4_moe_backend
what's the reason that these two can't be merged?
This was referenced Apr 28, 2026
Closed
5 tasks
3 tasks
4 tasks
This was referenced Apr 29, 2026
4 tasks
3 tasks
4 tasks
This was referenced May 20, 2026
4 tasks
fxmarty-amd
reviewed
Jun 24, 2026
| Mxfp4MoeBackend.TRITON_UNFUSED, | ||
| # TRITON_UNFUSED has bug with MTP support | ||
| # TODO re-enable after kernel is fixed | ||
| # TRITON_UNFUSED |
Contributor
There was a problem hiding this comment.
Any context on this @ivanium ? Which test specifically dispatched on TRITON_UNFUSED and caused failures?
Collaborator
Author
There was a problem hiding this comment.
Good questions. cc @zyongye and @jeejeelee who have more details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Rebased version of #40760
Roadmap: #40902
Co-authored by: Bugen Zhao, Giancarlo Delfin, Jie Li, Kaichao You, Roy Wang, Woosuk Kwon, Yifan Qiao, Yongye Zhu, Zhewen Li, Zijing Liu, Zixi Qi
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.