refactor: use strings.SplitSeq for streaming iteration (#516)

Replaces `strings.Split` with `strings.SplitSeq` in to iterate over split results without allocating an intermediate slice.

This reduces memory allocations and enables streaming-style processing.

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>

Author: tenthirtyam

builder/vmware/common/driver_parser.go

@@ -2270,7 +2270,7 @@ func decodeDhcpdLeaseBytes(input string) ([]byte, error) {
 	processed := &bytes.Buffer{}
 
 	// Split the string into pieces as we'll need to validate it.
-	for _, item := range strings.Split(input, ":") {
+	for item := range strings.SplitSeq(input, ":") {
 		if len(item) != 2 {
 			return []byte{}, fmt.Errorf("bytes are not well-formed (%v)", input)
 		}

builder/vmware/common/vmx.go

@@ -21,7 +21,7 @@ func ParseVMX(contents string) map[string]string {
 
 	lineRe := regexp.MustCompile(`^(.+?)\s*=\s*"?(.*?)"?\s*$`)
 
-	for _, line := range strings.Split(contents, "\n") {
+	for line := range strings.SplitSeq(contents, "\n") {
 		matches := lineRe.FindStringSubmatch(line)
 		if matches == nil {
 			continue