refactor: use slices.Contains for membership checks (#515)

Replaces manual loops that checked for membership with `slices.Contains` for clarity and brevity. 

Behavior unchanged; this is a readability/maintenance refactor.

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>

Author: tenthirtyam

builder/vmware/common/cdrom_utils.go

@@ -7,6 +7,7 @@ package common
 import (
 	"fmt"
 	"regexp"
+	"slices"
 	"strconv"
 	"strings"
 )
@@ -21,13 +22,7 @@ func FindNextAvailableCDROMSlot(vmxData map[string]string, adapterType string) (
 	adapterType = strings.ToLower(adapterType)
 
 	validAdapters := []string{"ide", "sata", "scsi"}
-	isValid := false
-	for _, valid := range validAdapters {
-		if adapterType == valid {
-			isValid = true
-			break
-		}
-	}
+	isValid := slices.Contains(validAdapters, adapterType)
 	if !isValid {
 		return "", fmt.Errorf("invalid adapter type: %s; must be one of %v", adapterType, validAdapters)
 	}

builder/vmware/common/driver_fusion.go

@@ -13,6 +13,7 @@ import (
 	"os/exec"
 	"path/filepath"
 	"runtime"
+	"slices"
 	"strings"
 
 	"github.com/hashicorp/go-version"
@@ -98,10 +99,8 @@ func (d *FusionDriver) IsRunning(vmxPath string) (bool, error) {
 		return false, err
 	}
 
-	for _, line := range strings.Split(stdout, "\n") {
-		if line == absVmxPath {
-			return true, nil
-		}
+	if slices.Contains(strings.Split(stdout, "\n"), absVmxPath) {
+		return true, nil
 	}
 
 	return false, nil

builder/vmware/common/driver_workstation.go

@@ -14,6 +14,7 @@ import (
 	"os/exec"
 	"path/filepath"
 	"runtime"
+	"slices"
 	"sort"
 	"strings"
 
@@ -176,10 +177,8 @@ func (d *WorkstationDriver) IsRunning(vmxPath string) (bool, error) {
 		return false, err
 	}
 
-	for _, line := range strings.Split(stdout, "\n") {
-		if line == vmxPath {
-			return true, nil
-		}
+	if slices.Contains(strings.Split(stdout, "\n"), vmxPath) {
+		return true, nil
 	}
 
 	return false, nil

builder/vmware/common/step_attach_tools_cdrom_test.go

@@ -8,6 +8,7 @@ import (
 	"context"
 	"os"
 	"path/filepath"
+	"slices"
 	"testing"
 
 	"github.com/hashicorp/packer-plugin-sdk/multistep"
@@ -97,13 +98,7 @@ displayName = "test"
 	}
 
 	tmpDevices := state.Get("temporaryDevices").([]string)
-	found := false
-	for _, device := range tmpDevices {
-		if device == "ide0:0" {
-			found = true
-			break
-		}
-	}
+	found := slices.Contains(tmpDevices, "ide0:0")
 	if !found {
 		t.Fatal("tools CD-ROM device should be added to temporaryDevices")
 	}

builder/vmware/common/step_clean_files.go

@@ -8,6 +8,7 @@ import (
 	"context"
 	"os"
 	"path/filepath"
+	"slices"
 
 	"github.com/hashicorp/packer-plugin-sdk/multistep"
 	packersdk "github.com/hashicorp/packer-plugin-sdk/packer"
@@ -33,11 +34,8 @@ func (StepCleanFiles) Run(ctx context.Context, state multistep.StateBag) multist
 		// virtual machine, we get rid of it.
 		keep := false
 		ext := filepath.Ext(path)
-		for _, goodExt := range skipCleanFileExtensions {
-			if goodExt == ext {
-				keep = true
-				break
-			}
+		if slices.Contains(skipCleanFileExtensions, ext) {
+			keep = true
 		}
 
 		if !keep {