Skip to content

refactor: use strings.Builder for string accumulation #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tenthirtyam merged 1 commit into from
Jun 23, 2026
Merged

refactor: use strings.Builder for string accumulation #513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions builder/vmware/common/driver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ func NewDriver(dconfig *DriverConfig, config *SSHConfig, vmName string) (Driver,
return nil, fmt.Errorf("error finding a driver for %s", runtime.GOOS)
}

errs := ""
var errs strings.Builder
for _, driver := range drivers {
err := driver.Verify()

Expand All @@ -362,10 +362,10 @@ func NewDriver(dconfig *DriverConfig, config *SSHConfig, vmName string) (Driver,
}

log.Printf("[INFO] Skipping %T because it failed with the following error %s", driver, err)
errs += "* " + err.Error() + "\n"
errs.WriteString("* " + err.Error() + "\n")
}

return nil, fmt.Errorf("driver initialization failed. fix at least one driver to continue:\n%s", errs)
return nil, fmt.Errorf("driver initialization failed. fix at least one driver to continue:\n%s", errs.String())
}

// runAndLog executes the given command, logs its execution, and returns its stdout, stderr, and any encountered error.
Expand Down
12 changes: 6 additions & 6 deletions builder/vmware/common/driver_parser_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ func uncommentFromString(s string) string {
inCh := consumeString(s)
out := uncomment(inCh)

result := ""
var result strings.Builder
for item := range out {
result += string(item)
result.WriteString(string(item))
}
return result
return result.String()
}

func TestParserUncomment(t *testing.T) {
Expand Down Expand Up @@ -492,11 +492,11 @@ func TestParserReadNetworkMap(t *testing.T) {
}

func collectIntoString(in chan byte) string {
result := ""
var result strings.Builder
for item := range in {
result += string(item)
result.WriteString(string(item))
}
return result
return result.String()
}

func TestParserConsumeUntilSentinel(t *testing.T) {
Expand Down
Loading