Skip to content

isoInstaller: fix interactive (no-kickstart) ISO install #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliverkurth merged 1 commit into from
Jun 5, 2026
Merged

isoInstaller: fix interactive (no-kickstart) ISO install #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions photon_installer/isoInstaller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,12 @@ def __init__(self, options, params={}):
else:
install_config = self._load_ks_config_platform(verify=not insecure_installation)

# 'live' should be True for iso installs
if 'live' not in install_config:
# 'live' should be True for iso installs. Only stamp it on an actual
# (non-empty) kickstart config. For an interactive install the config
# is empty here and must stay falsy, otherwise installer.configure()
# ('if not install_config and ui_config') skips the UI configurator
# and _check_install_config() fails with "No disk configured".
if install_config and 'live' not in install_config:
install_config['live'] = True

if insecure_installation and install_config is not None:
Expand Down Expand Up @@ -164,7 +168,10 @@ def _load_ks_config_platform(self, verify=True):
if CommandUtils.is_vmware_virtualization():
return self._load_ks_config_vmware(verify=verify)
else:
return None
# No platform-provided kickstart: fall back to an interactive
# install with an empty config. Returning None here makes the
# caller crash at "if 'live' not in install_config".
return {}

def _load_ks_config_vmware(self, verify=True):
try:
Expand All @@ -191,6 +198,10 @@ def _load_ks_config_vmware(self, verify=True):
print(
f"Failed to run vmtoolsd, do you have open-vm-tools installed? Error: {e}"
)
# No guestinfo kickstart (data/url both absent) or vmtoolsd missing:
# fall back to an interactive install with an empty config instead of
# returning None, which would crash at "if 'live' not in install_config".
return {}

def mount_media(self, photon_media, mount_path=Defaults.MOUNT_PATH):
"""Mount the external media"""
Expand Down
Loading