chore: use shared constants - #654
Merged
tenthirtyam merged 1 commit intoJun 22, 2026
Merged
Conversation
tenthirtyam
changed the title
tenthirtyam
marked this pull request as draft
June 19, 2026 15:49
tenthirtyam
force-pushed
the
chore/use-shared-test-constants-in-tkgaws-tests
branch
2 times, most recently
from
June 19, 2026 16:19
3d5dae9 to
28c6fee
Compare
tenthirtyam
changed the title
Replace repeated hard-coded literals with named constants to centralize values and reduce duplication. Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
tenthirtyam
force-pushed
the
chore/use-shared-test-constants-in-tkgaws-tests
branch
from
June 19, 2026 16:24
28c6fee to
461d8b1
Compare
tenthirtyam
marked this pull request as ready for review
June 19, 2026 16:27
vivgoyal
approved these changes
Jun 22, 2026
Contributor
|
Looks like linter is failing for this PR |
Contributor
Author
|
It's failing because the changes are across two PRs to address all of the linting. :) |
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace repeated hard-coded test literals with named constants to centralize values and reduce duplication.
This will help resolve the current CI failures for golangci-lint related for goconst.
Type
Please describe:
Breaking Changes?
Test and Documentation
Issue References
Additional Information