feat/ipfs refactor#1137
Draft
altergui wants to merge 2 commits into
Draft
Conversation
altergui
commented
Oct 9, 2023
Contributor
- ipfs: add EnableLocalDiscovery option
- ipfs: refactor removing very old clutter and abstractions
Contributor
Author
|
our current way of initializing IPFS is absolutely convoluted, so i'm working towards a simplification (WIP) right now, this is a code snippet used by census3 for example which doesn't look terrible, but: passing a new option (besides dataDir) is almost impossible i believe it would make much more sense to end up with something like this: that would also allow me to add options through IPFSCfg, much more easily |
* data.Storage.Init now needs no args * move DataMockTest into its own package datamock * assert at compile time that datamock.DataMockTest and ipfs.Handler satisfy data.Storage * move fsrepo.IsInitialized check into startNode * remove ancient abstraction types.DataStore * fixup "ipfs: add EnableLocalDiscovery option": move field EnableLocalDiscovery into ipfs.Handler
3da1c4c to
8ed7aa2
Compare
Contributor
Author
|
here's more progress but still there's a lot of duplication that i want to remove |
Pull Request Test Coverage Report for Build 6863543637
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.