indexer: backups are now a deterministic set of SQL statements#1338
Draft
altergui wants to merge 1 commit into
Draft
indexer: backups are now a deterministic set of SQL statements#1338altergui wants to merge 1 commit into
altergui wants to merge 1 commit into
Conversation
Pull Request Test Coverage Report for Build 9498381141Details
💛 - Coveralls |
altergui
force-pushed
the
feat/deterministic-indexer-backups
branch
2 times, most recently
from
062a1a5 to
cc46776
Compare
Pull Request Test Coverage Report for Build 9498587081Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9498735272Details
💛 - Coveralls |
mvdan
approved these changes
Jun 14, 2024
mvdan
left a comment
mvdan
left a comment
Contributor
There was a problem hiding this comment.
Thanks for doing this. I said I would, but haven't had the time. LGTM with some nits.
Did you consider a test? Just to make sure that we don't regress with any other non-determinism in SQL backups in the future.
Also, I wonder if we should rename the indexer sql "backup" feature to "snapshot", as the latter is perhaps more well understood to mean "deterministic".
| statement.WriteString(line) | ||
| statement.WriteString("\n") | ||
|
|
||
| if strings.HasSuffix(line, ";") { |
Contributor
There was a problem hiding this comment.
are you sure that the entire text ends with ;? what if it's like
foo;
bar;
baz
in that case you would ignore baz, so perhaps add a sanity check at the end that there's no remaining statement.
Member
|
Could you explain why this is now deterministic? thanks |
altergui
force-pushed
the
feat/deterministic-indexer-backups
branch
from
cc46776 to
47767ee
Compare
Pull Request Test Coverage Report for Build 9546598969Details
💛 - Coveralls |
Contributor
Author
|
it's deterministic because the SQL statements produced by each node are the same (bit-by-bit) . this was not the case with the raw db format. |
they are a (zstd compressed) set of SQL statements also, relevant methods now use io.Reader and io.Writer
altergui
force-pushed
the
feat/deterministic-indexer-backups
branch
from
47767ee to
f345045
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is much less performant that simply exporting/importing the raw binary database, but makes the backup deterministic, allowing StateSync to pull the snapshot from many nodes at the same time