Skip to content

qalculate: update to 3.17.0#28844

Closed
folliehiyuki wants to merge 2 commits intovoid-linux:masterfrom
folliehiyuki:qalculate
Closed

qalculate: update to 3.17.0#28844
folliehiyuki wants to merge 2 commits intovoid-linux:masterfrom
folliehiyuki:qalculate

Conversation

@folliehiyuki
Copy link
Copy Markdown
Contributor

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@ericonr
Copy link
Copy Markdown
Member

ericonr commented Feb 19, 2021

Argh, they seem to have broken all cross builds. Take a look at their commit log around the build system to see if you can find what it was.

@folliehiyuki
Copy link
Copy Markdown
Contributor Author

I think it is around commit Qalculate/libqalculate@8c45269 that breaks the cross builds

@ericonr
Copy link
Copy Markdown
Member

ericonr commented Feb 23, 2021

Indeed, specifically with the addition of the fixpo program.

We have a workaround for a similar issue in the goaccess package, if you want to look. A possibly upstreamable solution is allinurl/goaccess#2038 , but it's not necessary for a simple patch to get it to build..

@folliehiyuki
Copy link
Copy Markdown
Contributor Author

I don't know much about compilers, but will take a look at what I can do.

@folliehiyuki
Copy link
Copy Markdown
Contributor Author

I've tried to do the same thing in goaccess for this package with no luck. Maybe I have done it wrong.
The build chain still fails when reaching those *.po files

@ericonr ericonr closed this in 89dc478 Feb 26, 2021
@ericonr
Copy link
Copy Markdown
Member

ericonr commented Feb 26, 2021

See cd6a601 for fix :)

@folliehiyuki folliehiyuki deleted the qalculate branch February 26, 2021 18:40
@folliehiyuki
Copy link
Copy Markdown
Contributor Author

Thanks. I know what I did wrong now :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants