docs: complete, correct and sort the Modbus RTU meter table#391
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the README’s “Modbus RTU Meters” documentation so the supported meter table matches the actual meters/rs485 producers and is easier to use from the CLI.
Changes:
- Expanded and corrected the supported Modbus RTU meter capability table (added missing meters, removed non-implemented/incorrect rows).
- Added a Type column to document the
-d <Type>:<id>identifier and sorted the table/notes alphabetically. - Refreshed and reorganized the descriptive notes below the table.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
We should probably auto-generate this (or remove it). Not sure how useful it is anyway. |
Contributor
Author
|
I don't know too. |
Contributor
|
Happy with the sourcery comments? |
premultiply
force-pushed
the
readme-meter-table
branch
from
316dbf3 to
d86fb65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The supported-meters table had drifted from the actual
meters/rs485producers. Capabilities below were derived directly from each producer’sProduce()output.Completeness — added 12 implemented meters that were missing: Carlo Gavazzi EM/ET 330/340, Chint DTSU666, DDM18SD, Finder 7M.24/7M.38, Lovato DMG610, Siemens PAC2200, SolarEdge SE-MTR-3Y, Wago 879-30xx, Eastron SDM72 v2 / SDM230 / SMART X96-1A.
Correctness
SDM530,Inepro PRO1/2.KOSTAL Smart Energy Meter— it is a SunSpec/TCP device (SUNS), not an RS485 producer.Usability — added a
Typecolumn with the actual type code for-d <Type>:<id>, and sorted both the table and the notes alphabetically.🤖 Generated with Claude Code