Allow more thorough checks of MultiPV lines - #166
Merged
Conversation
Contributor
Author
|
Example run for SF12: |
Contributor
Author
|
I will keep track of improvements for the new files in robertnurnberg/matetools#127, in case others would like to contribute. Once enough improvements have accumulated, I would open a PR on the matetrack repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following two functional changes to the matecheck script, together with the associated new files
matetrack_multipv.epdandmatedtrack_multipv.epd.--checkMultiPVsand now always check PVs of sidelines for completeness and correctness--multipvFileto allow providing (conjectured optimal)bmvalues for child positions, so that too short and wrongly signed mate scores can also be caught in MultiPV sidelinesSample output for the example run
python matecheck.py --epdFile matetrack.epd matedtrack.epd --nodes 1000 --bmMin 4 --bmMax 4 --multiPV 4 --multipvFile matetrack_multipv.epd matedtrack_multipv.epd --engine ./sf12:The format of the two new files
matetrack_multipv.epdandmatedtrack_multipv.epdis explained in their headers:Clearly, these two files will evolve over time, as we find more and faster mates for the positions they store. But for standard invocations of the matecheck script, their current state should already suffice.