Move noask_file_text to platform#1946
Draft
ekohl wants to merge 1 commit into
Draft
Conversation
ekohl
commented
Aug 12, 2025
| if !check_for_command('pkgutil') | ||
| # https://www.opencsw.org/package/pkgutil/ | ||
| noask_text = self.noask_file_text | ||
| noask_text = self['platform'].noask_file_text |
Member
Author
There was a problem hiding this comment.
This is the only use. Should it instead move to a private helper in this class?
This really depends on the platform and doesn't belong in the file abstraction.
Member
Author
|
The tests should be moved too. Before I do, I'd like an answer to #1946 (comment) |
Member
|
How likely is it that people use beaker to test solaris 10? can't we just drop the code? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This really depends on the platform and doesn't belong in the file abstraction.