Remove use of wmic

lib/beaker/host/pswindows/exec.rb

@@ -61,26 +61,16 @@ def path
   end
 
   def get_ip
-    # when querying for an IP this way the return value can be formatted like:
-    # IPAddress=
-    # IPAddress={"129.168.0.1"}
-    # IPAddress={"192.168.0.1","2001:db8:aaaa:bbbb:cccc:dddd:eeee:0001"}
+    ips = execute('powershell.exe -NoProfile -NonInteractive -Command "(Get-CimInstance Win32_NetworkAdapterConfiguration -Filter \'IPEnabled=True\' | ForEach-Object { $_.IPAddress })"')
 
-    ips = execute("wmic nicconfig where ipenabled=true GET IPAddress /format:list")
-
-    ip = ''
     ips.each_line do |line|
-      matches = line.split('=')
-      next if matches.length <= 1
-
-      matches = matches[1].match(/^{"(.*?)"/)
-      next if matches.nil? || matches.captures.nil? || matches.captures.empty?
+      ip = line.strip
+      next unless ip.match?(/^\d{1,3}(?:\.\d{1,3}){3}$/)
 
-      ip = matches.captures[0] if matches && matches.captures
-      break if ip != ''
+      return ip
     end
 
-    ip
+    ''
   end
 
   # Attempt to ping the provided target hostname

lib/beaker/host/pswindows/group.rb

@@ -2,10 +2,13 @@ module PSWindows::Group
   include Beaker::CommandFactory
 
   def group_list
-    execute('cmd /c echo "" | wmic group where localaccount="true" get name /format:value') do |result|
+    execute('powershell.exe -NoProfile -NonInteractive -Command "Get-CimInstance Win32_Group -Filter \'LocalAccount=True\' | Select-Object -ExpandProperty Name"') do |result|
       groups = []
       result.stdout.each_line do |line|
-        groups << (line.match(/^Name=(.+)$/) or next)[1]
+        group = line.strip
+        next if group.empty?
+
+        groups << group
       end
 
       yield result if block_given?

lib/beaker/host/pswindows/pkg.rb

@@ -24,7 +24,7 @@ def uninstall_package(_name, _cmdline_args = '')
     0
   end
 
-  # Examine the host system to determine the architecture, overrides default host determine_if_x86_64 so that wmic is used
+  # Examine the host system to determine the architecture
   # @return [Boolean] true if x86_64, false otherwise
   def determine_if_x86_64
     identify_windows_architecture.include?('AMD64')

lib/beaker/host/pswindows/user.rb

@@ -2,10 +2,13 @@ module PSWindows::User
   include Beaker::CommandFactory
 
   def user_list
-    execute('cmd /c echo "" | wmic useraccount where localaccount="true" get name /format:value') do |result|
+    execute('powershell.exe -NoProfile -NonInteractive -Command "Get-CimInstance Win32_UserAccount -Filter \'LocalAccount=True\' | Select-Object -ExpandProperty Name"') do |result|
       users = []
       result.stdout.each_line do |line|
-        users << (line.match(/^Name=(.+)/) or next)[1]
+        user = line.strip
+        next if user.empty?
+
+        users << user
       end
 
       yield result if block_given?

lib/beaker/host/windows/exec.rb

@@ -24,26 +24,16 @@ def path
   end
 
   def get_ip
-    # when querying for an IP this way the return value can be formatted like:
-    # IPAddress=
-    # IPAddress={"129.168.0.1"}
-    # IPAddress={"192.168.0.1","2001:db8:aaaa:bbbb:cccc:dddd:eeee:0001"}
+    ips = execute('powershell.exe -NoProfile -NonInteractive -Command "(Get-CimInstance Win32_NetworkAdapterConfiguration -Filter \'IPEnabled=True\' | ForEach-Object { $_.IPAddress })"')
 
-    ips = execute("wmic nicconfig where ipenabled=true GET IPAddress /format:list")
-
-    ip = ''
     ips.each_line do |line|
-      matches = line.split('=')
-      next if matches.length <= 1
-
-      matches = matches[1].match(/^{"(.*?)"/)
-      next if matches.nil? || matches.captures.nil? || matches.captures.empty?
+      ip = line.strip
+      next unless ip.match?(/^\d{1,3}(?:\.\d{1,3}){3}$/)
 
-      ip = matches.captures[0] if matches && matches.captures
-      break if ip != ''
+      return ip
     end
 
-    ip
+    ''
   end
 
   # Attempt to ping the provided target hostname

lib/beaker/host/windows/group.rb

@@ -2,10 +2,13 @@ module Windows::Group
   include Beaker::CommandFactory
 
   def group_list
-    execute('cmd /c echo "" | wmic group where localaccount="true" get name /format:value') do |result|
+    execute('powershell.exe -NoProfile -NonInteractive -Command "Get-CimInstance Win32_Group -Filter \'LocalAccount=True\' | Select-Object -ExpandProperty Name"') do |result|
       groups = []
       result.stdout.each_line do |line|
-        groups << (line.match(/^Name=(.+)$/) or next)[1]
+        group = line.strip
+        next if group.empty?
+
+        groups << group
       end
 
       yield result if block_given?
@@ -14,7 +17,7 @@ def group_list
     end
   end
 
-  # using powershell commands as wmic is deprecated in windows 2025
+  # using powershell commands as wmic is deprecated/removed on newer Windows
   def group_list_using_powershell
     execute('cmd /c echo "" | powershell.exe "Get-LocalGroup | Select-Object -ExpandProperty Name"') do |result|
       groups = []

lib/beaker/host/windows/pkg.rb

@@ -29,7 +29,7 @@ def uninstall_package(name, _cmdline_args = '')
     raise "Package #{name} cannot be uninstalled on #{self}"
   end
 
-  # Examine the host system to determine the architecture, overrides default host determine_if_x86_64 so that wmic is used
+  # Examine the host system to determine the architecture
   # @return [Boolean] true if x86_64, false otherwise
   def determine_if_x86_64
     identify_windows_architecture.include?('64')

lib/beaker/host/windows/user.rb

@@ -2,10 +2,13 @@ module Windows::User
   include Beaker::CommandFactory
 
   def user_list
-    execute('cmd /c echo "" | wmic useraccount where localaccount="true" get name /format:value') do |result|
+    execute('powershell.exe -NoProfile -NonInteractive -Command "Get-CimInstance Win32_UserAccount -Filter \'LocalAccount=True\' | Select-Object -ExpandProperty Name"') do |result|
       users = []
       result.stdout.each_line do |line|
-        users << (line.match(/^Name=(.+)/) or next)[1]
+        user = line.strip
+        next if user.empty?
+
+        users << user
       end
 
       yield result if block_given?
@@ -14,7 +17,7 @@ def user_list
     end
   end
 
-  # using powershell commands as wmic is deprecated in windows 2025
+  # using powershell commands as wmic is deprecated/removed on newer Windows
   def user_list_using_powershell
     execute('cmd /c echo "" | powershell.exe "Get-LocalUser | Select-Object -ExpandProperty Name"') do |result|
       users = []

spec/beaker/host/pswindows/exec_spec.rb

@@ -48,6 +48,14 @@ def to_s
       end
     end
 
+    describe '#get_ip' do
+      it 'returns the first IPv4 address from CIM output' do
+        output = "fe80::1\n192.168.0.1\n10.0.0.2\n"
+        expect(instance).to receive(:execute).with(/Win32_NetworkAdapterConfiguration/).and_return(output)
+        expect(instance.get_ip).to eq('192.168.0.1')
+      end
+    end
+
     describe '#modified_at' do
       before do
         allow(instance).to receive(:execute).and_return(stdout)

spec/beaker/host/pswindows/user_spec.rb

@@ -5,33 +5,17 @@ class PSWindowsUserTest
 end
 
 describe PSWindowsUserTest do
-  let(:wmic_output) do
+  let(:user_list_output) do
     <<~EOS
-      Name=Administrator
+      Administrator
 
+      bob foo
 
+      bob-dash
 
+      bob.foo
 
-
-      Name=bob foo
-
-
-
-
-
-      Name=bob-dash
-
-
-
-
-
-      Name=bob.foo
-
-
-
-
-
-      Name=cyg_server
+      cyg_server
 
 
 
@@ -42,22 +26,22 @@ class PSWindowsUserTest
 
     EOS
   end
-  let(:command) { 'cmd /c echo "" | wmic useraccount where localaccount="true" get name /format:value' }
+  let(:command) { %q(powershell.exe -NoProfile -NonInteractive -Command "Get-CimInstance Win32_UserAccount -Filter 'LocalAccount=True' | Select-Object -ExpandProperty Name") }
   let(:host) { double.as_null_object }
   let(:result) { Beaker::Result.new(host, command) }
 
   describe '#user_list' do
     it 'returns user names list correctly' do
-      result.stdout = wmic_output
+      result.stdout = user_list_output
       expect(subject).to receive(:execute).with(command).and_yield(result)
       expect(subject.user_list).to be === ['Administrator', 'bob foo', 'bob-dash', 'bob.foo', 'cyg_server']
     end
 
     it 'yields correctly with the result object' do
-      result.stdout = wmic_output
+      result.stdout = user_list_output
       expect(subject).to receive(:execute).and_yield(result)
       subject.user_list do |result|
-        expect(result.stdout).to be === wmic_output
+        expect(result.stdout).to be === user_list_output
       end
     end
   end

spec/beaker/host/windows/exec_spec.rb

@@ -60,6 +60,14 @@ def to_s
       end
     end
 
+    describe '#get_ip' do
+      it 'returns the first IPv4 address from CIM output' do
+        output = "fe80::1\n192.168.0.1\n10.0.0.2\n"
+        expect(instance).to receive(:execute).with(/Win32_NetworkAdapterConfiguration/).and_return(output)
+        expect(instance.get_ip).to eq('192.168.0.1')
+      end
+    end
+
     describe '#cygwin_installed?' do
       let(:response) { double('response') }
 

spec/beaker/host/windows/group_spec.rb

@@ -12,25 +12,24 @@ class WindowsGroupTest
       let(:result) { double(:result, :stdout => group_list_output) }
       let(:group_list_output) do
         <<~EOS
-          Name=Foo
+          Foo
 
-
-          Name=Bar6
+          Bar6
 
 
         EOS
       end
 
       def add_group(group_name)
         group_list_output << <<~EOS
-          Name=#{group_name}
+          #{group_name}
 
 
         EOS
       end
 
       before do
-        expect(instance).to receive(:execute).with(/wmic group where/).and_yield(result)
+        expect(instance).to receive(:execute).with(/Win32_Group/).and_yield(result)
       end
 
       it "gets a group_list" do

spec/beaker/host/windows/user_spec.rb

@@ -9,35 +9,19 @@ class WindowsUserTest
   let(:result) { Beaker::Result.new(host, command) }
 
   describe '#user_list' do
-    let(:command) { 'cmd /c echo "" | wmic useraccount where localaccount="true" get name /format:value' }
+    let(:command) { %q(powershell.exe -NoProfile -NonInteractive -Command "Get-CimInstance Win32_UserAccount -Filter 'LocalAccount=True' | Select-Object -ExpandProperty Name") }
 
-    let(:wmic_output) do
+    let(:user_list_output) do
       <<~EOS
-        Name=Administrator
-
-
-
-
-
-        Name=bob foo
-
-
-
-
-
-        Name=bob-dash
-
-
-
-
-
-        Name=bob.foo
-
+        Administrator
 
+        bob foo
 
+        bob-dash
 
+        bob.foo
 
-        Name=cyg_server
+        cyg_server
 
 
 
@@ -50,16 +34,16 @@ class WindowsUserTest
     end
 
     it 'returns user names list correctly' do
-      result.stdout = wmic_output
+      result.stdout = user_list_output
       expect(subject).to receive(:execute).with(command).and_yield(result)
       expect(subject.user_list).to be === ['Administrator', 'bob foo', 'bob-dash', 'bob.foo', 'cyg_server']
     end
 
     it 'yields correctly with the result object' do
-      result.stdout = wmic_output
+      result.stdout = user_list_output
       expect(subject).to receive(:execute).and_yield(result)
       subject.user_list do |result|
-        expect(result.stdout).to be === wmic_output
+        expect(result.stdout).to be === user_list_output
       end
     end
   end