feat: Rework filesystem lock and force full cleanup of modules and releases on discovery#67
Open
riton wants to merge 1 commit into
Open
feat: Rework filesystem lock and force full cleanup of modules and releases on discovery#67riton wants to merge 1 commit into
riton wants to merge 1 commit into
Conversation
Member
|
Hi @riton! As you may see, |
riton
force-pushed
the
feature/rework_locks_and_refresh
branch
from
252d748 to
1eba3ea
Compare
…leases on rediscovery
Contributor
Author
|
Hi @jay7x Somehow, I've completely missed your message 🤦 This PR is now rebased ✔️ Regards |
Member
|
Dear @voxpupuli/gorge maintainers, I need your help here. I don't have much multu-threading coding experience, so please have a look if you do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This P.R initial goal was to ensure that a removed module from the filesystem would be detected and reflected in the WebUI. In my tests, it appeared that in
backend/filesystem.goLoadModulesfunction,s.Modulesands.Releaseswould still contain modules or releases that were removed from the filesystem.I've adapted a few read only locks along the patch.
What do you think ?