Conversation
9b6e9bc to
851336f
Compare
|
@TheBigLee does this actually work? CNPG does not use an STS since the pods are directly managed by the operator |
|
Guess I missed one alert here: https://github.com/vshn/component-appcat/pull/1101/changes Also, as @mikeshootzz your solution might not work as CNPG doesn't use STS. My fix actually looks at the labels and filters via them. |
851336f to
687fc9d
Compare
You are right. The correct label is not |
Hm. Not sure If I should use your solution or stick with mine. WDYT? |
687fc9d to
a425745
Compare
For consistency’s sake I would stick with the solution we already have |
I'd use the same solution. Because otherwise it gets more complicated. |
The alert considers every pod starting with `postgresql-`. This includes all the backup pods as well. Since the backup pods are not cleared up immediately, this alert fires all the time. Restricting the alert to only the cluster pods, solves the issue. Signed-off-by: Nicolas Bigler <nicolas.bigler@vshn.ch>
a425745 to
c05c9cf
Compare
Ok. Fixed to change to use the same as approach as you did earlier |
The alert considers every pod starting with
postgresql-. This includes all the backup pods as well. Since the backup pods are not cleared up immediately, this alert fires all the time.Restricting the alert to only the cluster pods, solves the issue.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
make e2e-testagainst local kindev and all checks passed