feat(VRating): expose activeColor in item slot props#22738
Open
mixelburg wants to merge 1 commit intovuetifyjs:masterfrom
Open
feat(VRating): expose activeColor in item slot props#22738mixelburg wants to merge 1 commit intovuetifyjs:masterfrom
mixelburg wants to merge 1 commit intovuetifyjs:masterfrom
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22273
Currently only
coloris passed to the#itemslot, even thoughactiveColoris a distinct prop that gets resolved separately. This makes it hard to useactiveColorfor custom rendering without manually re-deriving it from props.The
activeColoris already computed initemState— this just includes it in the returned object so it shows up in the slot payload alongsidecolor.Before:
After: