feat(VCarousel): add stopOnHover prop to pause cycling on hover#22739
Open
mixelburg wants to merge 2 commits intovuetifyjs:masterfrom
Open
feat(VCarousel): add stopOnHover prop to pause cycling on hover#22739mixelburg wants to merge 2 commits intovuetifyjs:masterfrom
mixelburg wants to merge 2 commits intovuetifyjs:masterfrom
Conversation
Contributor
|
new prop qualifies this for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10544
Adds a
stop-on-hoverprop toVCarousel. When set alongsidecycle, the auto-cycling pauses while the user hovers over the carousel and resumes when they move away.The implementation adds an
isHoveredref andonMouseenter/onMouseleavehandlers on the rootVWindow. The handlers are no-ops unlessstopOnHoveris true, so there's no runtime cost for the default case. ThestartTimeoutguard also checksisHovered.valueso a programmatic restart (e.g. slide change) won't queue the next tick while hovering.Usage: