fix(VVideoControls): import VVideo.sass to ensure styles are bundled with tree shaking#22749
Open
mixelburg wants to merge 1 commit intovuetifyjs:masterfrom
Open
fix(VVideoControls): import VVideo.sass to ensure styles are bundled with tree shaking#22749mixelburg wants to merge 1 commit intovuetifyjs:masterfrom
mixelburg wants to merge 1 commit intovuetifyjs:masterfrom
Conversation
…with tree shaking When using VVideoControls or VVideoVolume without importing VVideo, production builds with tree shaking would omit the .v-video-controls styles (defined in VVideo.sass) since only VVideo.tsx imported the stylesheet. Fix by importing VVideo.sass at the top of VVideoControls.tsx and VVideoVolume.tsx so their styles are included regardless of which components from the VVideo family are imported. Fixes vuetifyjs#22529
Contributor
|
The correct way would be to split the main stylesheet into dedicated files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #22529
When
VVideoControls(orVVideoVolume) is used in an app without importingVVideo, production builds with tree shaking skip theVVideo.sassstylesheet — because onlyVVideo.tsximported it. The result is unstyled controls in production (vite build+vite preview) while dev mode works fine (Vite doesn't tree-shake in dev).Fix
Add
import './VVideo.sass'to the top of bothVVideoControls.tsxandVVideoVolume.tsx. This is the same pattern used throughout Vuetify (e.g. every component that needs styles imports its own.sassfile directly). Adding the import to both ensures styles are included whenever any of the three VVideo sub-components is used standalone.