fix(VDataTable/Headers/Header/Row): hide mobile thead when required#22791
Draft
fix(VDataTable/Headers/Header/Row): hide mobile thead when required#22791
Conversation
userquin
commented
Apr 4, 2026
| return [...v.values()] | ||
| }) | ||
| const selectedItemsCount = computed(() => selected.value.size) | ||
| const allItemsCount = computed(() => allItems.value.length) |
Member
Author
There was a problem hiding this comment.
not sure if this is fine: I need to check the strategies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes:
disableSort(and no sortable columns) and uses the append slot when sort is enabled and there is at least 1 sortable column (changed sortableColumns composable to return empty array whenprops.disableSortis true)dataTable.ariaLabelto include labels or aria-label attributes for row checkbox selection: included in all locales (using Gemini PRO for the translations)isSelectedandisExpandedonly onceStill on draft, I think I forgot to add some transtation at
tsxfiles, I'm reviewing the code: maybe I also need to change the new props at data table, header and row.Markup:
Playground