python: replace bare except clauses with specific exception types by andamasov · Pull Request #5074 · vyos/vyos-1x

andamasov · 2026-03-20T20:04:59Z

Summary

Replace all bare except: clauses with specific exception types across 5 files
Bare except: catches all exceptions including KeyboardInterrupt and SystemExit, which can mask critical errors and prevent proper program termination

Changes

File	Exception Type	Rationale
`src/conf_mode/interfaces_ethernet.py:162`	`Exception`	Interface MTU lookup may fail for various OS-level reasons
`src/conf_mode/vpp_interfaces_bonding.py:181`	`ValueError`	`assert_mac()` raises `ValueError` on invalid MAC
`src/conf_mode/container.py:180`	`IndexError`	List comprehension `[0]` on empty filtered list
`src/conf_mode/container.py:186`	`IndexError`	List comprehension `[0]` on empty filtered list
`python/vyos/config.py:124`	`Exception`	ACME cert loading can fail from file I/O, parsing, etc.
`python/vyos/configverify.py:49`	`Exception`	Interface min/max MTU sysfs reads may fail
`python/vyos/configverify.py:436`	`(TypeError, ValueError)`	`str()` conversion of DH keysize parameter

Test plan

Verify ethernet interface configuration still works when MTU cannot be read from adapter
Verify VPP bonding rejects invalid MAC addresses with proper error message
Verify container network address validation catches missing IPv4/IPv6 prefixes
Verify ACME certificate loading gracefully handles missing/corrupt certificates
Verify MTU validation falls back to defaults when sysfs is unavailable
Verify Diffie-Hellman key length verification handles invalid input

🤖 Generated with Claude Code

Bare except clauses catch all exceptions including KeyboardInterrupt and SystemExit, which can mask critical errors and prevent proper program termination. Replace each bare except with the appropriate specific exception type: - interfaces_ethernet.py: except Exception (interface MTU lookup) - vpp_interfaces_bonding.py: except ValueError (MAC validation) - container.py: except IndexError (prefix list indexing) - config.py: except Exception (ACME certificate loading) - configverify.py: except Exception (MTU min/max lookup) - configverify.py: except (TypeError, ValueError) (DH key conversion) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions · 2026-03-20T20:05:10Z

❌
PR title does not match the required format

github-actions · 2026-03-20T20:05:10Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

andamasov · 2026-03-20T20:07:22Z

I have read the CLA Document and I hereby sign the CLA

Copilot

Pull request overview

This PR aims to improve Python exception handling safety by replacing bare except: clauses with specific exception types so that KeyboardInterrupt/SystemExit aren’t accidentally swallowed during config processing.

Changes:

Replaced bare except: with except ValueError around MAC validation in VPP bonding verification.
Replaced bare except: with except IndexError in container IP prefix selection logic.
Replaced bare except: with except Exception (and one except (TypeError, ValueError)) in MTU/DH/acme-related helper functions.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`src/conf_mode/vpp_interfaces_bonding.py`	Narrows MAC validation exception handling to `ValueError`.
`src/conf_mode/interfaces_ethernet.py`	Narrows MTU clamping exception handling to `Exception`.
`src/conf_mode/container.py`	Narrows list-indexing exception handling to `IndexError` for prefix lookups.
`python/vyos/configverify.py`	Narrows MTU fallback exception handling to `Exception`; narrows DH keysize conversion handling to `(TypeError, ValueError)`.
`python/vyos/config.py`	Narrows ACME cert/key loading exception handling to `Exception`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/conf_mode/vpp_interfaces_bonding.py

src/conf_mode/container.py

- vpp_interfaces_bonding: forward actual ValueError message instead of hardcoded multicast error, since assert_mac raises for multiple reasons - container: catch KeyError and TypeError alongside IndexError for prefix lookups, since 'prefix' key may not exist Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-20T20:16:47Z

python/vyos/configverify.py

    try:
        keysize = str(min_keysize)
-    except:
+    except (TypeError, ValueError):
        return False


verify_diffie_hellman_length() currently wraps only str(min_keysize) in try/except, but the later int(min_keysize) conversion can still raise ValueError for inputs like 'abc', causing an exception instead of returning False. Also, the local variable keysize is unused. Consider validating/converting min_keysize once (e.g., to an int) inside the try/except and then using that value for comparisons.

github-actions · 2026-03-20T21:51:31Z

CI integration 👍 passed!

Details

CI logs

CLI Smoketests 👍 passed
CLI Smoketests (interfaces only) 👍 passed
Config tests 👍 passed
RAID1 tests 👍 passed
CLI Smoketests VPP 👍 passed
Config tests VPP 👍 passed
TPM tests 👍 passed

github-actions bot assigned andamasov Mar 20, 2026

github-actions bot added the current label Mar 20, 2026

andamasov requested a review from Copilot March 20, 2026 20:05

Copilot started reviewing on behalf of andamasov March 20, 2026 20:06 View session

vyosbot added a commit to vyos/vyos-cla-signatures that referenced this pull request Mar 20, 2026

@andamasov has signed the CLA in vyos/vyos-1x#5074

5c286b3

Copilot AI reviewed Mar 20, 2026

View reviewed changes

src/conf_mode/vpp_interfaces_bonding.py Outdated Show resolved Hide resolved

src/conf_mode/container.py Show resolved Hide resolved

src/conf_mode/container.py Outdated Show resolved Hide resolved

andamasov requested a review from Copilot March 20, 2026 20:13

Copilot started reviewing on behalf of andamasov March 20, 2026 20:13 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

python: replace bare except clauses with specific exception types#5074

python: replace bare except clauses with specific exception types#5074
andamasov wants to merge 2 commits intocurrentfrom
fix/bare-except-clauses

andamasov commented Mar 20, 2026

Uh oh!

github-actions bot commented Mar 20, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 20, 2026 •

edited

Loading

Uh oh!

andamasov commented Mar 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

andamasov commented Mar 20, 2026

Summary

Changes

Test plan

Uh oh!

github-actions bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andamasov commented Mar 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 20, 2026

Details

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Mar 20, 2026 •

edited

Loading

github-actions bot commented Mar 20, 2026 •

edited

Loading