Skip to content

T8448: VRRP add configuration for the SNMP traps#5108

Open
sever-sever wants to merge 1 commit intovyos:currentfrom
sever-sever:T8448
Open

T8448: VRRP add configuration for the SNMP traps#5108
sever-sever wants to merge 1 commit intovyos:currentfrom
sever-sever:T8448

Conversation

@sever-sever
Copy link
Copy Markdown
Member

Change summary

Allow to configure Keepalived VRRP traps

  • set high-availability vrrp snmp trap

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

set high-availability vrrp group GRP-01 address 192.0.2.1
set high-availability vrrp group GRP-01 interface 'eth1'
set high-availability vrrp group GRP-01 vrid '1'
set high-availability vrrp snmp trap

Check config, expected option enable_traps in the global_defs

vyos@r14# cat /run/keepalived/keepalived.conf 
# Autogenerated by VyOS
# Do not edit this file, all your changes will be lost
# on next commit or reboot

# Global definitions configuration block
global_defs {
    dynamic_interfaces
    enable_traps
    script_user root
    notify_fifo /run/keepalived/keepalived_notify_fifo
    notify_fifo_script /usr/libexec/vyos/system/keepalived-fifo.py
}


vrrp_instance GRP-01 {
    state BACKUP
    interface eth1
    virtual_router_id 1
    priority 100
    advert_int 1
    preempt_delay 0
    virtual_ipaddress {
        192.0.2.1
    }
}

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Allow to configure Keepalived VRRP traps
 - set high-availability vrrp snmp trap
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

👍
No issues in PR Title / Commit Title

@sever-sever sever-sever added the bp/circinus Create automatic backport for circinus label Apr 3, 2026
Copy link
Copy Markdown
Member

@c-po c-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a smoketest validating keepalived.conf.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests 👍 passed
  • CLI Smoketests (interfaces only) ❌ failed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • CLI Smoketests VPP 👍 passed
  • Config tests VPP 👍 passed
  • TPM tests 👍 passed

Copy link
Copy Markdown
Contributor

@natali-rs1985 natali-rs1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. Works as expected

vyos@vyos# set high-availability vrrp snmp trap 
[edit]
vyos@vyos# commit
[edit]
vyos@vyos# cat /run/keepalived/keepalived.conf 
# Autogenerated by VyOS
# Do not edit this file, all your changes will be lost
# on next commit or reboot

# Global definitions configuration block
global_defs {
    dynamic_interfaces
    enable_traps
    script_user root
    notify_fifo /run/keepalived/keepalived_notify_fifo
    notify_fifo_script /usr/libexec/vyos/system/keepalived-fifo.py
}
[edit]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bp/circinus Create automatic backport for circinus current

Development

Successfully merging this pull request may close these issues.

3 participants