remote: T4732: add VRF option for commit-archive#5115
Open
c-po wants to merge 2 commits intovyos:currentfrom
Open
remote: T4732: add VRF option for commit-archive#5115c-po wants to merge 2 commits intovyos:currentfrom
c-po wants to merge 2 commits intovyos:currentfrom
Conversation
Add new CLI option to make transfers to the commit-archive working using a dedicated (e.g. management) VRF. set system config-management commit-archive vrf MGMT All transfers using vyos.remote module will now run through the VRF defined on the CLI.
|
👍 |
1 task
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new commit-archive vrf CLI option so commit-archive uploads can run in a dedicated VRF (e.g., a management VRF), wiring the setting through config-management into the remote transfer layer.
Changes:
- Extend the CLI schema for
system config-management commit-archivewith avrfleaf. - Read the effective
commit-archive vrffrom config and pass it into commit-archive uploads. - Add VRF-aware plumbing to
vyos.remotetransfer implementations (HTTP(S), SSH, TFTP/curl, git).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
src/conf_mode/system_config-management.py |
Validates commit-archive configuration including VRF existence via verify_vrf(). |
python/vyos/config_mgmt.py |
Reads effective commit-archive vrf and passes it to remote uploads for commit-archive. |
python/vyos/remote.py |
Adds vrf parameter propagation and implements VRF binding/wrapping for several protocols. |
interface-definitions/system_config-management.xml.in |
Adds vrf CLI node under commit-archive. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6716775 to
56d98d7
Compare
The upload error message echoes the full urlstring, which may include embedded credentials (e.g., https://user:pass@host/...). With this commit the information has been redacted.
|
CI integration ❌ failed! Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
Add new CLI option to make transfers to the commit-archive working using a dedicated (e.g. management) VRF.
set system config-management commit-archive vrf MGMTAll transfers using vyos.remote module will now run through the VRF defined on the CLI.
Types of changes
Related Task(s)
Related PR(s)
How to test / Smoketest result
Using
tcpdump(1)one can see the packets now traverse viaeth0.10which is bound to VRFMGMTChecklist: