This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Release preparation - #8
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the project for release by transitioning from custom Kubernetes deployment scripts to a professional Helm chart distribution. It introduces a complete Helm chart with comprehensive configuration options and establishes GitHub Pages hosting for chart distribution.
- Replaces manual deployment scripts with a Helm chart for Kubernetes-native package management
- Adds GitHub Actions workflow for automated chart testing, packaging, and hosting
- Introduces comprehensive configuration options and example values for different environments
Reviewed Changes
Copilot reviewed 28 out of 30 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
scripts/validate-chart.sh |
New script for Helm chart validation with linting, templating, and manifest testing |
scripts/undeploy.sh |
Removed legacy deployment script in favor of Helm-based deployment |
scripts/test.sh |
Removed basic build test script |
scripts/github-setup.sh |
Removed GitHub repository setup script |
scripts/dev.sh |
Removed development startup script |
scripts/deploy.sh |
Removed manual Kubernetes deployment script |
scripts/build.sh |
Removed Docker build script |
helm/passkey-auth/values.yaml |
Complete Helm chart configuration with production-ready defaults |
helm/passkey-auth/templates/* |
Kubernetes resource templates for Deployment, Service, Ingress, ConfigMap, Secret, etc. |
helm/passkey-auth/Chart.yaml |
Helm chart metadata and versioning information |
helm/passkey-auth/README.md |
Comprehensive documentation for chart installation and configuration |
.github/workflows/helm-release.yml |
GitHub Actions workflow for automated chart testing and release |
.github/cr.yaml |
Chart releaser configuration for GitHub Pages hosting |
docker-compose.yml |
Updated environment variables and configuration path |
README.md |
Streamlined documentation focusing on Helm installation |
| ) | ||
|
|
||
| for value in "${REQUIRED_VALUES[@]}"; do | ||
| if helm template test-release $CHART_DIR --show-only templates/configmap.yaml | grep -q "REQUIRED"; then |
There was a problem hiding this comment.
The grep check for "REQUIRED" will not work correctly. The logic is inverted - when grep finds "REQUIRED", it returns 0 (success), but the script treats this as an error condition. This should use ! grep -q "REQUIRED" or check the exit code differently.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR does.
Type of Change