Skip to content

fix(fossa): exclude v3/examples npm targets from license scan#5497

Open
taliesin-ai wants to merge 1 commit into
wailsapp:masterfrom
taliesin-ai:translations/2026-05-23-67a27ae8
Open

fix(fossa): exclude v3/examples npm targets from license scan#5497
taliesin-ai wants to merge 1 commit into
wailsapp:masterfrom
taliesin-ai:translations/2026-05-23-67a27ae8

Conversation

@taliesin-ai

@taliesin-ai taliesin-ai commented May 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Updates .fossa.yml to exclude all npm targets under v3/examples/ from FOSSA license scanning
  • Follows the same pattern as the existing website/ exclusion
  • Example app frontends are dev/demo tooling, not distributed artifacts

Context

PR #5333 (feat(v3:notifications): add sounds, attachments, and more) introduced v3/examples/notifications/frontend/package-lock.json which includes newer rollup platform binaries (rollup 4.60.3 adds targets for OpenHarmony, LoongArch64, ppc64-musl) that aren't in any existing example frontend. FOSSA flagged these as 3 compliance issues.

All packages are MIT-licensed — this is not a real license risk. The fix excludes all v3/examples/ npm targets from FOSSA scanning, consistent with the documented policy that compliance posture covers only distributed artifacts (the Go module and @wailsio/runtime).

This should be merged before or alongside PR #5333.

CC @leaanthony

Summary by CodeRabbit

  • Chores
    • Updated license scanning configuration to exclude example and demo directories from scan scope, with clarification comments added.

Review Change Stack

Example-app frontends are demo/development tooling and are not
distributed as part of the Wails Go module or @wailsio/runtime.
Adding them to the FOSSA exclude list keeps the compliance posture
focused on distributed artifacts and prevents spurious failures when
example frontends pull in new platform-specific package binaries
that FOSSA has not yet reviewed for this project.
@coderabbitai

coderabbitai Bot commented May 23, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ea9e8ae4-c8d3-44dc-81f7-25e088226ae4

📥 Commits

Reviewing files that changed from the base of the PR and between dc3f120 and d9f16d6.

📒 Files selected for processing (1)
  • .fossa.yml

Walkthrough

Updated .fossa.yml to exclude v3/examples from npm license scans alongside the website path. Added clarifying comments explaining that example/demo frontends and build-time dependencies are not distributed with the Wails Go module or @wailsio/runtime package.

Changes

License Scanning Configuration

Layer / File(s) Summary
Expand npm license scan exclusions with documentation
.fossa.yml
Extended targets.exclude to exclude both website and v3/examples paths. Added inline comments clarifying that these are example/demo frontends and associated build-time dependencies not distributed with the Wails Go module or @wailsio/runtime package.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

  • wailsapp/wails#5472: Both PRs update .fossa.yml to add npm targets.exclude for build-time tooling directories with matching rationale about excluding local demo/doc artifacts from the distributed packages.

Poem

🐰 A config tweak, so tidy and light,
Examples tucked away, out of sight,
Comments added for those who shall read,
License scans run with clarity indeed!
Wails keeps moving forward so bright! 🚀

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is mostly complete with summary, context, and rationale, but does not follow the repository's required template structure and lacks the required checklists and testing information. Fill in the PR description template with sections for Type of Change, Testing details, and all required checklists to align with repository standards.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: excluding v3/examples npm targets from FOSSA license scanning, which is the primary objective of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@taliesin-ai

Copy link
Copy Markdown
Collaborator Author

Bump: this PR is blocking the FOSSA License Compliance check on PR #5333. PR #5333 is otherwise ready to merge (all other CI checks pass, all code review threads resolved, documentation complete). Merging this PR into master first (or alternatively, the contributor can cherry-pick this change into their PR #5333 branch) will unblock the merge.

CC @leaanthony


Taliesin is an AI agent. CC @leaanthony

@leaanthony leaanthony left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean and correct — exclusion for npm targets follows the same established pattern as the exclusion. These are dev/demo artifacts, not distributed.

@leaanthony leaanthony enabled auto-merge (squash) June 7, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants