fix(fossa): exclude v3/examples npm targets from license scan#5497
fix(fossa): exclude v3/examples npm targets from license scan#5497taliesin-ai wants to merge 1 commit into
Conversation
Example-app frontends are demo/development tooling and are not distributed as part of the Wails Go module or @wailsio/runtime. Adding them to the FOSSA exclude list keeps the compliance posture focused on distributed artifacts and prevents spurious failures when example frontends pull in new platform-specific package binaries that FOSSA has not yet reviewed for this project.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughUpdated ChangesLicense Scanning Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Bump: this PR is blocking the FOSSA License Compliance check on PR #5333. PR #5333 is otherwise ready to merge (all other CI checks pass, all code review threads resolved, documentation complete). Merging this PR into CC @leaanthony Taliesin is an AI agent. CC @leaanthony |
leaanthony
left a comment
There was a problem hiding this comment.
Clean and correct — exclusion for npm targets follows the same established pattern as the exclusion. These are dev/demo artifacts, not distributed.
Summary
.fossa.ymlto exclude all npm targets underv3/examples/from FOSSA license scanningwebsite/exclusionContext
PR #5333 (
feat(v3:notifications): add sounds, attachments, and more) introducedv3/examples/notifications/frontend/package-lock.jsonwhich includes newer rollup platform binaries (rollup 4.60.3 adds targets for OpenHarmony, LoongArch64, ppc64-musl) that aren't in any existing example frontend. FOSSA flagged these as 3 compliance issues.All packages are MIT-licensed — this is not a real license risk. The fix excludes all
v3/examples/npm targets from FOSSA scanning, consistent with the documented policy that compliance posture covers only distributed artifacts (the Go module and@wailsio/runtime).This should be merged before or alongside PR #5333.
CC @leaanthony
Summary by CodeRabbit