refactor(mobile): enforce result model invariants

[szijpeter]

Summary

Tightens the Kotlin and Swift mobile wallet output models so callers cannot construct contradictory or incomplete result states.

This builds on the presentation-result hierarchy merged in walt-id/waltid-identity#1892 and keeps its ready and invalid preview states correctly separated.

What Changed

Event Results

• Replaces open event value objects with closed Kotlin and Swift enums covering every wallet-core issuance and presentation event, including prepared presentation responses.
• Maps the core Kotlin enum exhaustively into the mobile enum and the SKIE-generated enum exhaustively into the Swift facade, so additions require an explicit mapping on both surfaces.
• Keeps stable event names and derives phase and status from the selected case instead of accepting contradictory constructor arguments.

Presentation Preview Results

• Makes client_id and nonce required, non-blank fields of a successfully prepared presentation preview.
• Gives invalid previews a separate partial request context with a required, non-blank client_id and an optional nonce, whose absence may itself be the validation error.
• Rejects empty credential requirements, empty alternatives, and blank query references.
• Applies the same non-blank reference invariant to returned credential options and transaction data.
• Rejects disclosures marked selectable unless they are both selectively disclosable and optional.
• Keeps the Kotlin, Swift, Compose demo, and native iOS demo models aligned.

Architecture Notes

• Events use enums rather than a sealed hierarchy because the domain is finite and the cases carry no case-specific payload.
• Ready previews expose validated MobileWalletPresentationRequestInfo / PresentationRequestInfo values with required client IDs and nonces. Invalid previews expose MobileWalletPresentationRequestContext / PresentationRequestContext, which retain the required client ID while allowing the nonce to be absent.
• Public result constructors remain available so integrators can build representative SDK values in tests and previews; constructor validation protects those public construction paths.
• The mobile facade enforces only invariants required for internally consistent return values. Protocol-level DCQL grammar and aggregate request validation remain outside this PR.

Caveats and Follow-Ups

• Mobile wallet configuration types and protocol-level DCQL validation are intentionally outside this result-model cleanup.

Breaking Changes

MobileWalletEvent and Swift WalletEvent are now closed enums. Callers constructing event fixtures must select a declared event case; Swift callers that parse a stable name can use the failable WalletEvent(name:) initializer.

MobileWalletPresentationRequestInfo.clientId / Swift PresentationRequestInfo.clientID and nonce are now non-optional and must be non-blank.

Invalid preview results now expose the separate partial MobileWalletPresentationRequestContext / PresentationRequestContext type. Its client ID is required and non-blank, while its nonce remains optional so missing-nonce validation errors can be represented.

Constructing internally inconsistent presentation output fixtures now fails immediately.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 406aa20d-d80c-4727-a8ea-3f195f47d360

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud