Skip to content

[WAL-896] fix(mobile): align strict request validation fixtures - #1962

Merged
szijpeter merged 20 commits into
feature/wal-896from
review/wal-896-mobile
Jul 22, 2026
Merged

[WAL-896] fix(mobile): align strict request validation fixtures#1962
szijpeter merged 20 commits into
feature/wal-896from
review/wal-896-mobile

Conversation

@szijpeter

Copy link
Copy Markdown
Contributor

Summary

Follow-up to walt-id/waltid-identity#1885 that merges the current main mobile metadata work, resolves the SDK/API conflicts, and restores CI-compatible mobile verifier fixtures without relaxing the hardened request policy.

The branch preserves the secure default for unsigned Request Objects while keeping explicitly configured legacy compatibility consistent across the normal and manual wallet presentation paths.

What Changed

Main integration

  • Merged main and retained both the OpenID4VP hardening from the parent PR and the current typed review-metadata, locale, and response-encryption SDK surface.
  • Regenerated the Kotlin ABI reference and corrected the merged Swift bridge/model declarations so the native iOS SDK compiles cleanly.

Mobile fixtures and tests

  • Create response-bound redirect_uri: demo verifier sessions and consume their direct authorization URLs instead of the unsigned JSON bootstrap endpoint.
  • Keep mobile integration wallets fail-closed for Request Objects while retaining the direct, response-bound demo path.
  • Update native iOS integration tests for the result-based preview API and structurally valid redirect_uri: client metadata.

Request-policy consistency

  • Propagate each wallet's configured unsigned-request policy through the manual request-resolution path.
  • Correct public KDoc to reference only the supported policy values.

Architecture Notes

  • Demo fixtures deliberately exercise a direct request bound to the verifier response URI; production Request Object handling remains strict by default.
  • The manual resolver now follows the same explicit compatibility policy as preview and presentation, rather than silently reverting to the secure default.

Caveats and Follow-Ups

  • This branch does not alter enterprise mobile implementation or CI wiring.
  • Native iOS PKIX support remains outside this follow-up's scope.

Breaking

  • None.

@linear-code

linear-code Bot commented Jul 22, 2026

Copy link
Copy Markdown

WAL-896

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 19a0c1e6-d08d-4539-ace1-a215e0d2a5c2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@szijpeter szijpeter added the ci:mobile Run mobile related CI workflows for this PR label Jul 22, 2026
@sonarqubecloud

Copy link
Copy Markdown

@szijpeter szijpeter self-assigned this Jul 22, 2026
@szijpeter szijpeter changed the title fix(mobile): align strict request validation fixtures [WAL-896] fix(mobile): align strict request validation fixtures Jul 22, 2026
@szijpeter
szijpeter marked this pull request as ready for review July 22, 2026 20:01
@szijpeter
szijpeter merged commit beb8e36 into feature/wal-896 Jul 22, 2026
95 of 114 checks passed
@szijpeter
szijpeter deleted the review/wal-896-mobile branch July 22, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:mobile Run mobile related CI workflows for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant