Skip to content

Fix/error responses - #1964

Merged
chsavvaidis merged 13 commits into
mainfrom
fix/error-responses
Jul 22, 2026
Merged

Fix/error responses#1964
chsavvaidis merged 13 commits into
mainfrom
fix/error-responses

Conversation

@chsavvaidis

@chsavvaidis chsavvaidis commented Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Align error responses for OAuth and OpenID4VCI

Type of Change

  • bug fix - change which fixes an issue
  • new feature - change which adds functionality

Checklist

  • code cleanup and self-review
  • unit + e2e test coverage
  • documentation updated accordingly

Breaking

  • -

chsavvaidis added 13 commits July 22, 2026 16:04
@chsavvaidis
chore(openid4vci): align credential error codes
4a5a0db
@chsavvaidis
refactor(openid4vci): split credential failure DTOs
750e8db
@chsavvaidis
feat(openid4vci): separate credential endpoint OAuth errors
287e2dc
@chsavvaidis
feat(openid4vci): resolve credential request targets
10788fd
@chsavvaidis
fix(openid4vci): map proof handler failures
fa7fe64
@chsavvaidis
test(openid4vci): cover final credential errors
3bc1c68
@chsavvaidis
fix(issuer2): use final credential endpoint errors
f0ec883
@chsavvaidis
test(issuer2): assert final credential error codes
d09c861
@chsavvaidis
Merge branch 'main' into fix/error-responses
ce4a0a1 
# Conflicts:
#	waltid-libraries/protocols/waltid-openid4vci/src/commonMain/kotlin/id/walt/openid4vci/core/DefaultOAuth2Provider.kt
#	waltid-libraries/protocols/waltid-openid4vci/src/commonMain/kotlin/id/walt/openid4vci/errors/OAuthError.kt
#	waltid-services/waltid-issuer-api2/src/main/kotlin/id/walt/issuer2/service/openid4vci/OpenId4VciProtocolService.kt
@chsavvaidis
fix(openid4vci): align OAuth credential errors with DPoP
8cfb921
@chsavvaidis
chore(issuer2): remove duplicate credential error import
9596816
@chsavvaidis
fix(issuer2): use OAuth invalid token for credential auth
d0ebc70
@chsavvaidis
test(openid4vci): expect OAuth failure for DPoP token binding
ad0b2d1
@sonarqubecloud

sonarqubecloud Bot commented Jul 22, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@coderabbitai

coderabbitai Bot commented Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4b350415-ecb9-4c99-9708-44b2aea00920

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chsavvaidis
chsavvaidis marked this pull request as ready for review July 22, 2026 14:36
@chsavvaidis
chsavvaidis merged commit 8674c7c into main Jul 22, 2026
52 checks passed
@chsavvaidis
chsavvaidis deleted the fix/error-responses branch July 22, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JakeFernandes98 JakeFernandes98 JakeFernandes98 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chsavvaidis @JakeFernandes98