Add AllReduce distributed strategy design#373
Open
QiJune wants to merge 5 commits into
Open
Conversation
QiJune
changed the title
QiJune
force-pushed
the
allreduce_design
branch
from
9dba66f to
59f653b
Compare
Codecov Report
@@ Coverage Diff @@
## develop #373 +/- ##
===========================================
- Coverage 87.75% 87.69% -0.07%
===========================================
Files 33 33
Lines 1503 1503
===========================================
- Hits 1319 1318 -1
- Misses 121 122 +1
Partials 63 63
|
QiJune
requested review from
Yancey0623,
shendiaomo,
typhoonzero and
wangkuiyi
Yancey0623
reviewed
Oct 28, 2020
|
|
||
| Single-process multi-GPU is not the recommended mode, | ||
| becase of its overhead of scatter/gather and GIL contention in every forward pass. | ||
| So, let's focus on DistributedDataParallel. |
Collaborator
There was a problem hiding this comment.
GoTorch does not have GIL, does single-process multi-GPU mode fits GoTorch?
Collaborator
Author
There was a problem hiding this comment.
The answer is no. There are two reasons:
-
The overhead of scatter/gather is also nonnegligible. We once use scatter/parallel do/gather to support multi-GPU AllReduce in Paddle with C++. From the experience, the speedup ratio is not very good.
-
We could only use scatter/gather in multi-GPU of one node. It could not be scaled to multi-node multi-GPU.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is for beter review